Closed Bug 549809 Opened 12 years ago Closed 12 years ago

Rename background-origin and background-clip properties and values to match css3-background

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- -

People

(Reporter: phiw2, Assigned: dbaron)

References

(Blocks 1 open bug)

Details

(Keywords: css3, dev-doc-complete, Whiteboard: [parity-opera][parity-webkit])

Attachments

(6 files)

Currently Gecko supports these as [padding][border][content], the CSS3 border & background module defines them as [padding-box][border-box][content-content]

http://www.w3.org/TR/css3-background/#the-background-clip
http://www.w3.org/TR/css3-background/#the-background-origin

Opera 10.50 and WebKit (safari 4) already support this.
My plan was to rename the values at the same time we renamed the properties, which we can do now that the draft is in CR.

Do we have another bug already on renaming the properties?
We might also want to fix bug 368085 before renaming the properties.
Status: UNCONFIRMED → NEW
blocking2.0: --- → ?
Ever confirmed: true
OS: Mac OS X → All
Priority: -- → P3
Hardware: x86 → All
Summary: Add support for the css3 border & background values for background-origin and background-clip → Rename background-origin and background-clip properties and values to match css3-background
Keywords: css3
Whiteboard: [parity-opera][parity-webkit]
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
I should file a separate bug for adding background-size to the shorthand.
Attachment #449456 - Flags: review?(roc)
(In reply to comment #7)
> I should file a separate bug for adding background-size to the shorthand.

filed bug 570326
Comment on attachment 449455 [details] [diff] [review]
patch 4: uncomment already-written code for background-clip and background-origin in background shorthand

           if (clip->mValue != origin->mValue) {
             aValue.Truncate();
             return NS_OK;
           }

Can you add a comment explaining what's happening here? I think we're deciding not to return a shorthand because the origin and clip need to be expressed separately?
Attachment #449455 - Flags: review?(roc) → review+
One general comment: it seems we're not leaving aliases in place for -moz-background-size/-moz-background-origin/-moz-background-clip. So existing content could break. Should we alias the old names to the new names?
I think the only time we've done that in the past was -moz-opacity, since there was a significant amount of content using it, and even then we removed it after a while.  We've taken the position that if authors were using these on the Web, they should have been doing:
  -moz-background-clip: ...
  /* other prefixes here, probably */
  background-clip: ...
all along.  Additionally, we want to minimize Gecko-specific content on the Web.
Also, I should file two followup bugs on things in the Editor's draft that haven't made CR yet:
 * adding origin+clip support to the shorthand (it now allows 2 values)
 * adding background-size support to the shorthand (changed since last CR, probably want to wait to implement until it hits CR again)
Should the dev-doc-needed keyword be set?
Keywords: dev-doc-needed
(In reply to comment #14)
> Also, I should file two followup bugs on things in the Editor's draft that
> haven't made CR yet:
>  * adding origin+clip support to the shorthand (it now allows 2 values)

bug 570896

>  * adding background-size support to the shorthand (changed since last CR,
> probably want to wait to implement until it hits CR again)

bug 570326 (I'd already filed it)
Depends on: 570909
These changes to the documentation are done.
Depends on: 624301
Depends on: 684672
No longer depends on: 684672
You need to log in before you can comment on or make changes to this bug.