549809 - Rename background-origin and background-clip properties and values to match css3-background

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[philippe (part-time)]

Currently Gecko supports these as [padding][border][content], the CSS3 border & background module defines them as [padding-box][border-box][content-content]

http://www.w3.org/TR/css3-background/#the-background-clip
http://www.w3.org/TR/css3-background/#the-background-origin

Opera 10.50 and WebKit (safari 4) already support this.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

My plan was to rename the values at the same time we renamed the properties, which we can do now that the draft is in CR.

Do we have another bug already on renaming the properties?

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We might also want to fix bug 368085 before renaming the properties.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 1: implement -moz-background-clip: content (to be renamed in later patch)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 2: remove comments representing removed no-clip value

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 3: rename properties and values of background-origin and background-clip

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 4: uncomment already-written code for background-clip and background-origin in background shorthand

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 5: also rename -moz-background-size to background-size

I should file a separate bug for adding background-size to the shorthand.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 6: re-alphabetize property-database.js

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #7)
> I should file a separate bug for adding background-size to the shorthand.

filed bug 570326

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 449455 [details] [diff] [review]
patch 4: uncomment already-written code for background-clip and background-origin in background shorthand

           if (clip->mValue != origin->mValue) {
             aValue.Truncate();
             return NS_OK;
           }

Can you add a comment explaining what's happening here? I think we're deciding not to return a shorthand because the origin and clip need to be expressed separately?

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

One general comment: it seems we're not leaving aliases in place for -moz-background-size/-moz-background-origin/-moz-background-clip. So existing content could break. Should we alias the old names to the new names?

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the only time we've done that in the past was -moz-opacity, since there was a significant amount of content using it, and even then we removed it after a while.  We've taken the position that if authors were using these on the Web, they should have been doing:
  -moz-background-clip: ...
  /* other prefixes here, probably */
  background-clip: ...
all along.  Additionally, we want to minimize Gecko-specific content on the Web.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/665863f2ac31
http://hg.mozilla.org/mozilla-central/rev/0f920bd875d7
http://hg.mozilla.org/mozilla-central/rev/b5562d977e3a
http://hg.mozilla.org/mozilla-central/rev/63ccfca7cdb2
http://hg.mozilla.org/mozilla-central/rev/c0bd45ab931f
http://hg.mozilla.org/mozilla-central/rev/979aceadf808

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also, I should file two followup bugs on things in the Editor's draft that haven't made CR yet:
 * adding origin+clip support to the shorthand (it now allows 2 values)
 * adding background-size support to the shorthand (changed since last CR, probably want to wait to implement until it hits CR again)

Comment 15

[Philip Chee]

Should the dev-doc-needed keyword be set?

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #14)
> Also, I should file two followup bugs on things in the Editor's draft that
> haven't made CR yet:
>  * adding origin+clip support to the shorthand (it now allows 2 values)

bug 570896

>  * adding background-size support to the shorthand (changed since last CR,
> probably want to wait to implement until it hits CR again)

bug 570326 (I'd already filed it)

Comment 17

[Eric Shepherd [:sheppy]]

These changes to the documentation are done.