550004 - [QA] Have your way with /themes

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P3)

Description

[Jeff Balogh (:jbalogh)]

zamboni: https://preview.addons.mozilla.org/en-US/firefox/themes/
remora: https://preview.addons.mozilla.org/en-US/firefox/browse/type:2/cat:all?sort=popular

They're using the same data, so they should be pretty much identical.

Comment 1

[Justin Scott [:fligtar]]

First pass:

1. This page says it has 16 add-ons but only has 15 https://preview.addons.mozilla.org/z/en-US/firefox/themes/animals?sort=downloads

2. Clicking Advanced search should have the tray drop down only on the right side of the page -- that categories bar should not go down with it. This also happens in production but should be fixed.

3. About and FAQ links in the footer don't work

4. The sidebar says 405 add-ons under "All" but adding the category counts gets 1336

5. Enabling experimental add-ons changes the All count but not category counts in the sidebar

6. There are 15 add-ons and only 1 page in the Animals category when experimental is not on. When experimental is on, there is 1 page, 16 add-ons, and 5 experimental add-ons. We somehow lost 4 public add-ons.

7. We should change Recommended text to Featured. I'm fine with inconsistency with [z] vs [r]

Comment 2

[Jeff Balogh (:jbalogh)]

(In reply to comment #1)
> First pass:
> 
> 1. This page says it has 16 add-ons but only has 15
> https://preview.addons.mozilla.org/z/en-US/firefox/themes/animals?sort=downloads

I only see 11.  But anyways, it looks like the category count is including experimental add-ons.  (16 comes from the category count, which is a cron job).

> 4. The sidebar says 405 add-ons under "All" but adding the category counts gets
> 1336

You can have an add-on in more than one catgory.  These counts bothered me too, but they're correct.

> 5. Enabling experimental add-ons changes the All count but not category counts
> in the sidebar

Category counts are from cron, so they won't be changed here.

Is it worth it to add experimental counts and the code to choose public_count vs. exp_count?  If we're going to be de-listing experimentals soon, we're not going to gain a lot there.
 
> 6. There are 15 add-ons and only 1 page in the Animals category when
> experimental is not on. When experimental is on, there is 1 page, 16 add-ons,
> and 5 experimental add-ons. We somehow lost 4 public add-ons.

Can you check this again?

Comment 3

[Jeff Balogh (:jbalogh)]

bug 550037, bug 550039, bug 550040 for #2, #3, #7.

Comment 4

[krupa raj[:krupa]]

xenophobia checkbox is missing from the footer.Are we getting rid of that feature in zamboni?

Comment 5

[krupa raj[:krupa]]

Behavior described in (1) in comment #1 is something we should consider fixing.

If we are giving people the option to choose whether they want to see  experimental add-ons or not,then the number of add-ons displayed in each category should change based on the user's selection.

Comment 6

[krupa raj[:krupa]]

moving to 5.10

Comment 7

[Wil Clouser [:clouserw]]

Load tests are good: https://wiki.mozilla.org/User:Clouserw/AMO/loadtest#.2Fthemes

Comment 8

[krupa raj[:krupa]]

looks good

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

w00t: https://addons.mozilla.org/en-US/firefox/themes/