550779 - Package error or possible missing file for contentprefs.xpt

Status: RESOLVED WORKSFORME

(Thunderbird :: Build Config, defect)

Description

[Nomis101]

If I build Thunderbird 3.2a1pre I see the following warning while packaging:

Warning: package error or possible missing or unnecessary file: Shredder.app/Contents/MacOS/components/contentprefs.xpt (package-manifest, 229).

I also see this in the Build Log from the official TB 3.next Nightlys, but not in the Build Log from Lanikai.
But I have no idea if contentprefs.xpt is needed and wasn't build. Or if contentprefs.xpt is obsolete in TB 3.next and wasn't ifndefed in package-manifest.in

Comment 1

[Phil Ringnalda (:philor)]

Want to know how to find out all that?

Generally, if foo.xpt existed, then there was a Makefile.in with "XPIDL_MODULE = foo", but since you don't know how much whitespace there was, searching for the regex "XPIDL_MODULE.*foo" is the lazy search that will find it. You know it was there in comm-192 since Lanikai isn't complaining, so search for http://mxr.mozilla.org/comm-1.9.2/search?string=XPIDL_MODULE.*contentprefs&regexp=1

That tells you that it used to be in /mozilla/toolkit/components/contentprefs/public/Makefile.in but once you load that file in mxr you can't change the dropdown to comm-central, which tells you the whole file is gone in comm-central, so in your comm-central tree, |cd mozilla|, then |hg log toolkit/components/contentprefs/public/Makefile.in| will tell you that the last thing that touched it was bug 524408, where you can see from the patch that the IDL moved over to DOM (a little more context in the patch would tell you it's now in dom_base.xpt), and we just forgot when we were adjusting packaging for the rest of the effects of that to ifdef the xpt. Now that we're branched, you can just remove it in comm-central's package-manifest.

Comment 2

[Nomis101]

Thanks for this helpfull elucidation :-)
I've tested it today, and I don't see the package error anymore, because it was ifdefed in package-manifest two weeks after I opened this bug: http://hg.mozilla.org/comm-central/rev/4812530ad1f6

Comment 3

[Phil Ringnalda (:philor)]

Heh. Didn't notice it was two months old.