550800 - "Summary" pref is overridden in multifeed folders

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Mike Cowperthwaite]

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.2.2pre)
 Gecko/20100307 Lanikai/3.1b2pre

If I create an RSS folder and subscribe multiple feeds to it, and ANY feed is set with the "show as summary" option turned OFF, then ALL feed items are shown as Web Page rather than Summary, regardless of the individual setting of the feed.  The Subscribe UI for each individual feed maintains its setting, but it is not possible to mix Summary with Web Page items.

Maybe not such a big deal.  Maybe the UI should be changed to present the option as a folder option rather than a feed option.

Comment 1

[Bernd Heinze]

Still valid with Seamonkey 2.1 (and before)

Comment 3

[alta88]

yes, mixing multifeeds in the same folder will return the summary/web page (quickmode=true for summary) to the first url key encountered in the feeds db.

it would be very difficult to fix this, as it would mean tracking the feed url of a message (not done currently) in either the header or as a msgDbHdr property.  then, all messages would have to be updated if the url ever changed.  very not worth it.

once bug 716706 is checked in, i intend to fix the Subscribe dialog to make it clear that the summary pref updates on a folder level and not feed level.

Comment 5

[alta88]

Attachment: patch.

1. the account default can now be updated from the Subscribe dialog.
2. summary checkbox enabled only for folders with feeds; changing the check applies to all feeds in the folder.
3. summary checkbox enabled for folders with feed URL field focused/non empty value, prior to add.

Comment 6

[alta88]

Attachment: patch.

updated patch with better keyboard handling and ensuring quickmode is correctly set on dnd operations.

Comment 7

[David :Bienvenu]

Not sure if this patch is the cause, but now I'm seeing this error when dropping a link to an rss feed:

Timestamp: 3/5/2012 3:47:19 PM
Warning: reference to undefined property this._rowMap[aIndex]._parent
Source File: chrome://messenger/content/folderPane.js
Line: 782

and the feed is not subscribed to. I'll try it w/o this patch.

Comment 8

[alta88]

i've seen that error, it happens the first time and is an old folderPane.js issue unrelated to any feed work.

also, there is a known issue that the open Subscribe dialog tree map is not updated (first time a dnd on folderpane is done) with the new feed.  if you close/open the dialog to rebuild the tree, it should be there.  if you remove it and repeat the dnd, then the dialog tree updates.

Comment 9

[David :Bienvenu]

Comment on attachment 602728 [details] [diff] [review]
patch.

usually we say params, not parms, for readability, but I'll leave it up to you.

+   * @param  [aParms] object           - additional parms.
    * @param  [aMode] integer           - action mode (default is kSubscribeMode)
    *                                     of the add.
    * 
    * @return success boolean           - true if edit checks passed and an
    *                                     async download has been initiated.
    */
-  addFeed: function(aFeedLocation, aFolder, aParse, aMode)
+  addFeed: function(aFeedLocation, aFolder, aParse, aParms, aMode)

Comment 10

[alta88]

Attachment: patch for checkin.

updated per comments.

Comment 11

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/ca6a6449f422