551597 - [AeroPeek] Selecting a tab preview for a minimized window un-maximize the window

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Marco Bonardo [:mak]]

steps to reproduce:
1. maximize browser window with a couple tabs
2. minimize to icon
3. select a tab preview from aero peek

Expected result:
window is restored as maximized

Actual result:
window is un-maximized

this looks like a regression of nightly Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a3pre) Gecko/20100310 Minefield/3.7a3pre
or at least i never saw it (but i did not actually check in yesterday's nightly)

Comment 1

[u88484]

Confirmed that this is a regression in today's nightly.  I think pretty much all the patches landed at the same time so I don't know how we can figure out with is the offending patch without someone locally backing out each patch.

Comment 2

[Alice0775 White]

regression window:

works:
http://hg.mozilla.org/mozilla-central/rev/7089c29da493
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a3pre) Gecko/20100309 Minefield/3.7a3pre ID:20100309154626

fails:
http://hg.mozilla.org/mozilla-central/rev/72f8d4f19dc7
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a3pre) Gecko/20100309 Minefield/3.7a3pre ID:20100309200316

pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7089c29da493&tochange=72f8d4f19dc7

Comment 5

[Gary [:streetwolf52]]

Perhaps this is the same bug. If I resize my FF window then exit out of FF and restart it the window is maximized.  It should maintain the size when I first exited it. Nothing to so with tab previews in this case.

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100320 Minefield/3.7a4pre - Build ID: 20100320112218

Comment 7

[Alice0775 White]

I backed out changeset http://hg.mozilla.org/mozilla-central/rev/fd270fe3c7fc
the issue does not happen.

Comment 8

[Jim Jeffery not reading bug-mail 1/2/11]

turning 'off' taskbar previews via the pref, then minimize the browser and restore from the TaskBar results in normal operation, so directly related to the previews.

Comment 9

[Jim Mathies [:jimm]]

WFM on the latest trunk nightly. Anyone else still seeing this?

Comment 10

[u88484]

(In reply to comment #9)
> WFM on the latest trunk nightly. Anyone else still seeing this?

Yep :(

Comment 11

[Alice0775 White]

I can reproduce the issue on the latest trunk nightly.
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100407 Minefield/3.7a4pre ID:20100407040554

Comment 12

[Jim Mathies [:jimm]]

Ah, my bad, I was looking at sys command changes and mixed this up with restoring from the context menu. This should be pretty easy to fix by grabbing the nsWindow object for the tab, get the top level window, and call show. I'll see if I can work something up.

Comment 13

[Jim Mathies [:jimm]]

Attachment: fix

Comment 14

[Jim Mathies [:jimm]]

argh, oopp habits die hard, I'll update the use of |true| to pr types when I land it.

Comment 15

[Rob Arnold [:robarnold]]

Comment on attachment 437614 [details] [diff] [review]
fix

Though this fixes the original problem, it introduces a regression - if you use the tab preview's context menu to restore the window, it no longer becomes active.

Comment 17

[Jim Mathies [:jimm]]

(In reply to comment #15)
> (From update of attachment 437614 [details] [diff] [review])
> Though this fixes the original problem, it introduces a regression - if you use
> the tab preview's context menu to restore the window, it no longer becomes
> active.

Hmm, not able to reproduce this. The steps I take:

1) open four or five tabs in a window
2) chose one, set the focus in a a text edit
3) minimize the window
4) hover over fx icon, right click tab's preview, select "Restore"

result: the window is restored, tab selected, focus is in the text edit

Comment 18

[Jim Mathies [:jimm]]

ahh, I see, selecting a tab that isn't selected when you minimize doesn't work.

Comment 19

[Filip Zakrzewski]

and sometimes tab that was selected when minimize window doesn't work

Comment 20

[Jim Mathies [:jimm]]

Attachment: fix

updated, this fixes a couple bugs, the tab selection from the context menu, and the original maximized window problem on restore.

Comment 22

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/f444c1024fd1

Comment 23

[u88484]

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100429 Minefield/3.7a5pre

Comment 24

[Kaleb Elwert]

I'm still having this issue with Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8
Will this be fixed, or do I need to update to a beta version?

Comment 25

[wundsalbe]

Either do I. Same problem with Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8

Comment 26

[Gingerbread Man]

https://bugzilla.mozilla.org/show_bug.cgi?id=587283
Seems to be a duplicate of this bug. Perhaps someone could mark it as such.

(In reply to comment #24)
> Will this be fixed, or do I need to update to a beta version?
Read the comment above yours. Either use Firefox 4.0 beta now or wait until the final version is released.

Comment 27

[Kaleb Elwert]

Still having issues with Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3) Gecko/20100805 Firefox/4.0b3, though it does the correct thing when minimized, it appears.