552176 - SeaMonkey missing a rule to always make icons show in Go/History menus on Ubuntu: port bug 508221

Status: NEW

(SeaMonkey :: Bookmarks & History, defect)

Description

[Sander]

chrome://global/content/xul.css has the following rules:
menuitem:not([type]):not(:-moz-system-metric(images-in-menus)) > .menu-iconic-left {
  visibility: hidden;
}

menu:not(:-moz-system-metric(images-in-menus)) > .menu-iconic-left {
  visibility: hidden;
}

Although Ubuntu (9.10) does support images-in-menus (I think; but I'm not certain exactly what this metric is supposed to signify beyond the MDC definition: https://developer.mozilla.org/en/CSS/:-moz-system-metric(images-in-menus) ), the :-moz-system-metric(images-in-menus) returns false, which makes the selector match, which hides the icons.

Firefox has the same rule in xul.css (and the same behaviour), but then in browser.css, it overrides things:

/* Bookmarks override the "images-in-menus" metric in xul.css */
.bookmark-item > .menu-iconic-left,
.searchbar-engine-menuitem > .menu-iconic-left {
  visibility: inherit;
}

I believe this rule should be carried over to SeaMonkey, too, to make icons show up again in the Bookmarks and Go menus. (Especially in the bookmarks menu this is greatly desired, as otherwise there's no way to distinguish between single bookmarks and bookmark groups.)

Comment 1

[Philip Chee]

See Firefox Bug 508221 (Favicons in search bar dropdown not shown if menus_have_icons=false)

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #0)
> (Especially in the bookmarks
> menu this is greatly desired, as otherwise there's no way to distinguish
> between single bookmarks and bookmark groups.)

FTR, that distinction is gone now anyway.

Comment 3

[Phoenix]

Still valid request
User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 SeaMonkey/2.15a1
Build identifier: 20120921003032

Comment 4

[Vedad Hadžić [:vedad][:vedadux]]

Hi, I am new to contributing to Mozilla.
I would like someone to guide me through fixing this bug. I am working on a Ubuntu 12.04 LTS maschine. Since i Know CSS, this could be a good bug to start with.

Comment 5

[Phoenix]

I suppose that you need to tweak
C:\Storage\hg\comm-central\suite\themes\classic\communicator\communicator.css
file, make same changes as in Firefox Bug 508221 patch

Comment 6

[Philip Chee]

(In reply to Vedad Hadžić from comment #4)
> Hi, I am new to contributing to Mozilla.
> I would like someone to guide me through fixing this bug. I am working on a
> Ubuntu 12.04 LTS maschine. Since i Know CSS, this could be a good bug to
> start with.

Hi! The first thing to do is to build SeaMonkey successfully.
You can read up on how to do this at:
https://developer.mozilla.org/en-US/docs/Simple_SeaMonkey_build

Also please join us on IRC for real time advice and help. Our IRC server is Moznet and our channel is SeaMonkey. If you have a IRC client available you can try using this URL:
irc://moznet/SeaMonkey

Once you're on IRC we can discuss further on how to proceed.

Comment 7

[Philip Chee]

(In reply to Phoenix from comment #5)
> I suppose that you need to tweak
> C:\Storage\hg\comm-central\suite\themes\classic\communicator\communicator.css
> file, make same changes as in Firefox Bug 508221 patch

Since Bug 508221 there have been changes in xul.css

http://hg.mozilla.org/mozilla-central/annotate/abe6790a5dd8/toolkit/content/xul.css#l371

>  :-moz-any(menuitem[type], .menuitem-with-favicon) > .menu-iconic-left {
>    visibility: visible;
>  }
So what we need to do is to make sure that the relevant menuitems have "menuitem-with-favicon" in their classList.

Comment 8

[[e-mail]]

(In reply to Philip Chee from comment #7)
> Since Bug 508221 there have been changes in xul.css
Bug 544762 added the menuitem-with-favicon class.
Bug 580676 added them to SeaMonkey's bookmarks as part of KaiRo's Places conversion.
Bug 401417 added them to SeaMonkey's search box when KaiRo added it to SeaMonkey.
Bug 751922 added them to SeaMonkey's session history menus as part of async favicons.
So there might not actually be anything left to do...

Comment 9

[Philip Chee]

I think there are a few bits left when I grepped /suite/ yesterday.

Comment 10

[Syed Ali]

I'm a student from coventry university studying an opensource module, I would like to be assigned this as my first bug! Could you please point me in the right direction of how to start

Comment 11

[Frank-Rainer Grahl (:frg)]

Syed,

this is quite an old bug. You would first need to verify that it is still present. I suggest trying 2.49.1 and check it out.

Comment 12

[sushant.co19]

I want to work on this issue

Comment 13

[Frank-Rainer Grahl (:frg)]

Sushant,

this is quite an old bug for the SeaMonkey browser. You would first need to verify that it is still present. I suggest trying 2.53.4 and check it out.

Comment 14

[sushant.co19]

It was on the top of codetribute page . so, I commented . Thanks for suggesting :)

Comment 15

[Favour]

Hi, I am outreachy applicants
I would like someone to guide me through fixing this bug. Since i Know CSS, this could be a good bug to start with.