552753 - Addons with beta versioning cannot update without a beta channel file

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P5)

Description

[Dave Garrett]

I was finished using the beta channel for now so I deleted all my beta files. However, users with a beta version installed are not getting updates to the latest public version. It just says there's no update available. If there aren't any beta files, and thus no beta channel, then all update pings should be treated the same and be served the latest public version.

Comment 1

[Jeff Balogh (:jbalogh)]

This is a special case of the larger problem: once you're on the beta channel, you're stuck there.

Comment 2

[Dave Garrett]

In the meantime I've devised a work around: create a multi-item XPI with a beta version number that contains the latest stable version. AMO sees this wrapper as a beta file and offers it as a beta channel update, then when a user installs it the stable version is installed, thus moving them over to the main channel.

Comment 3

[custom.firefox.lady [:tawn]]

I get the same behavior when trying to update a beta version obtained from the extension's homepage. Despite never having uploaded any beta files to amo at all. These users were never informed they were placed on a (non-existing) beta channel and are now required to update manually.

Comment 4

[Justin Scott [:fligtar]]

If an add-on has no beta files on AMO we should not go through any beta update logic.

Comment 6

[Dave Garrett]

Andy: This does not appear to be the same issue as bug 630561. That bug might fix this one, in which case we could mark it as a dependent and fixed, but I'm not sure it is based on that bug's comments and the fix. Please clarify: if no beta files exist, will a beta file update to a public file, which is this bug. Bug 630561 mentions disabled beta files existing in bug 630561 comment 3.

Comment 7

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> If an add-on has no beta files on AMO we should not go through any beta update
> logic.

That means that without any beta channels beta checks would get normal offerings.  Andym - is this happening in the new versioncheck stuff?

Comment 8

[Andy McKay]

Sorry I missed your comment Dave. If there's no files your addon will move to being disabled and then you will get updated to the next beta release, so I think you'll be ok with the new changes.

 If you let me know what addon, Dave, I'll take a look for you to double check.

Comment 9

[Dave Garrett]

(In reply to comment #8)
The addon I initially filed this bug in reference to is Flagfox, but I am currently using the beta channel and have two beta files. Last year I did a beta test period and then deleted all the beta files to have all the beta users update to the new stable channel public file, but that didn't work. This bug is requesting the ability to provide beta file users with a stable update if there are no beta files, and thus no beta channel, to allow developers to end beta testing periods and migrate those beta users to the main update channel.

Comment 10

[Andy McKay]

Ah sorry, if there's no files it falls back to staying on the beta channel. Changing in the python version.

Comment 11

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/c54c95c909389bfcc7d94ee3e679acb9d3bff71d

Comment 12

[Dave Garrett]

I deleted my old remaining beta file and updated a Firefox profile with it installed. It immediately went from no updates available to updating to the latest current stable version.

Verified fixed. Thanks.