553646 - No installed addons view should have a link to AMO or something

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Tony Chung [:tchung]]

Attachment: No Addons View screenshot

Seeing a blank space if nothing is installed is troubling. at least have a link to AMO or something.  This is for all other panes outside of Discovery.

See screenshot


Repro:
1) install addons branch build: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a4pre) Gecko/20100319 Minefield/3.7a4pre
2) open addons manager
3) Verify with no addons installed, the view of all the panes (except Discovery), is boring and bland.  

Expected:
- Have some sort of link to AMO, message, ad, whatever in a blank pane.  Anything is better than whiteness.

Actual:
- boring white box.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Fixed this with the fix to bug 553485.

http://hg.mozilla.org/projects/addonsmgr/rev/8c2ef649d47e
http://hg.mozilla.org/projects/addonsmgr/rev/8811cb8b019b

Comment 2

[Dave Townsend [:mossop]]

Landed on trunk as a part of bug 554007

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So this works for now but we still have an open question here. What if there are already system-wide add-ons installed? I thought we didn't wanted to take care about those when showing the button reported on this bug. On Windows and Linux will always find an extension installed.

Shall I file a new bug on that?

Comment 4

[Dave Townsend [:mossop]]

(In reply to comment #3)
> So this works for now but we still have an open question here. What if there
> are already system-wide add-ons installed? I thought we didn't wanted to take
> care about those when showing the button reported on this bug. On Windows and
> Linux will always find an extension installed.
> 
> Shall I file a new bug on that?

Let's take it to a new bug.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100517 Minefield/3.7a5pre

(In reply to comment #4)
> > Shall I file a new bug on that?
> 
> Let's take it to a new bug.

Filed as bug 566608. Tests should be added there.