554138 - enable building/uploading breakpad symbols on Linux-64 builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P4)

Description

[(not currently active) Ted Mielczarek]

Once we enable building the Breakpad code in bug 554021, we should enable building and uploading symbols on the Linux-64 builds.

Comment 1

[Armen [:armenzg]]

Thanks for reminding me! Too much going on :)

Comment 2

[(not currently active) Ted Mielczarek]

Note that this needs the blocking bug fixed first.

Comment 3

[Armen [:armenzg]]

OK lowering priority until then.

Comment 4

[(not currently active) Ted Mielczarek]

This is ready to go now. (I didn't resolve the dep bug yet, I should split off the ARM part of it.)

Comment 6

[Armen [:armenzg]]

Attachment: [WIP] really allow disabling build symbols

It seems that even if I have "uploadSymbols" to False it runs buildsymbols regardless.
I will test this patch later on to see that it doesn't affect other builders.

Having said that, we are currently generating Linux64 symbols:
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64/1271330610/firefox-3.7a5pre.en-US.linux-x86_64.crashreporter-symbols.zip

Comment 7

[Armen [:armenzg]]

Attachment: upload symbols for Linux64

Comment 8

[Armen [:armenzg]]

Comment on attachment 439230 [details] [diff] [review]
upload symbols for Linux64

Passing it to bear since this is related on knowing on what things are needed to bring up to speed a platform.

Comment 9

[[e-mail] (:bhearsum)]

(In reply to comment #6)
> Created an attachment (id=439229) [details]
> [WIP] really allow disabling build symbols
> 
> It seems that even if I have "uploadSymbols" to False it runs buildsymbols
> regardless.
> I will test this patch later on to see that it doesn't affect other builders.

I'm pretty sure this behaviour is intended. We need symbols built in order generate stack traces for 'make check' and leak tests.

In any case, I don't think uploadSymbols=False should mean "don't build symbols". If we don't need fine grained control this should be renamed to something that encompasses building and uploading symbols. If we need fine grained control to eg, have symbols local tests but not upload them, we should add a buildSymbols option.

Comment 10

[Armen [:armenzg]]

Comment on attachment 439230 [details] [diff] [review]
upload symbols for Linux64

http://hg.mozilla.org/build/buildbot-configs/rev/a6997e0d7dbd

Comment 11

[Armen [:armenzg]]

Let me know if I am missing anything.