Closed Bug 554021 Opened 11 years ago Closed 10 years ago

enable compiling Breakpad on Linux/x86-64 by default

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(status1.9.2 .5-fixed)

RESOLVED FIXED
mozilla1.9.3a5
Tracking Status
status1.9.2 --- .5-fixed

People

(Reporter: ted, Assigned: ted)

References

Details

(Whiteboard: [first patch was fixed in mozilla1.9.3a4])

Attachments

(1 file, 1 obsolete file)

bug 548113 landed some symbol dumper changes as well as client changes to support Linux/x86-64 and Linux/ARM. We should start compiling the client code there by default. We'll need to take a minidump_stackwalk update on the server first, since the symbols produced will include new STACK CFI records that the current processor won't understand.
Assignee: nobody → ted.mielczarek
Blocks: 554138
This broke on the try server maemo builds because scratchbox doesn't have libcurl-dev. :-/
Depends on: 554999
I split this patch into two parts, since Linux/ARM needs a build slave update. This one just cleans up the block where we select which targets get Breakpad enabled by default, and adds Linux/x86-64 to that list.
Attachment #435133 - Flags: review?(jim)
Status: NEW → ASSIGNED
Attached patch enable Breakpad on Linux/ARM (obsolete) — Splinter Review
And this enables it for Linux/ARM.
Attachment #435134 - Flags: review?(jim)
After fixing a few minor things, I'm still hitting an internal compiler error compiling in Scratchbox:
/home/cltbld/mozilla-central/toolkit/crashreporter/google-breakpad/src/common/linux/language.cc:76: internal compiler error: in reference_to_unused, at dwarf2out.c:10094

(irony: gcc erroring in its dwarf-producing code compiling our dwarf-consuming code.)
Comment on attachment 435133 [details] [diff] [review]
enable Breakpad on Linux/x86-64
[Checkin: Comment 8]

>+i?86-apple-darwin*|powerpc-apple-darwin*)
>+  MOZ_CRASHREPORTER=1

Can we generate PowerPC crashes?  I didn't find the code to do so...

Otherwise, looks good to me.
Attachment #435133 - Flags: review?(jim) → review+
If we were to delta-reduce that source file to find out what's causing the ICE, I wonder if that would suggest a way to work around it?
Comment on attachment 435134 [details] [diff] [review]
enable Breakpad on Linux/ARM

We obviously can't land this, but the patch itself looks good to me.
Attachment #435134 - Flags: review?(jim) → review+
Comment on attachment 435133 [details] [diff] [review]
enable Breakpad on Linux/x86-64
[Checkin: Comment 8]

Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/74ffccda23b8

Maybe I should split ARM off into a separate bug.
This caused build failures on debug linux x64 with

ac_add_options --enable-debug="-gstabs+"
export CFLAGS="-gstabs+"
export CXXFLAGS="-gstabs+"

firefox-debug/dist/lib/libxpcomglue_s.a(nsGenericFactory.o): In function `nsGenericFactory::GetClassID(nsID**)':

mozilla/xpcom/glue/nsGenericFactory.cpp:143: undefined reference to `nsMemory::Clone(void const*, unsigned long)'

/usr/bin/ld: mozilla/firefox-debug/dist/lib/libxpcomglue_s.a(nsGenericFactory.o): relocation R_X86_64_PC32 against `nsMemory::Clone(void const*, unsigned long)' can not be used when making a shared object; recompile with -fPIC

/usr/bin/ld: final link failed: Bad value

opt builds fine with

export CFLAGS="-gstabs+"
export CXXFLAGS="-gstabs+"

What are the appropriate mozconfig settings for debug 64bit linux now?
Er, I dunno, the tinderbox Linux64 debug builds are just fine using this mozconfig:
http://hg.mozilla.org/build/buildbot-configs/file/3ed8c28d1dcc/mozilla2/linux64/mozilla-central/debug/mozconfig

Are you sure it was this changeset? That error doesn't look like anything related to this.

FWIW, you can switch to -gdwarf-2 now if you want.
Blocks: 555674
I split Linux/ARM off to bug 555674. I'll reattach the ARM patch there.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
No longer depends on: 554999
Resolution: --- → FIXED
Summary: enable compiling Breakpad on Linux/x86-64 and Linux/ARM by default → enable compiling Breakpad on Linux/x86-64 by default
Target Milestone: --- → mozilla1.9.3a4
Comment on attachment 435134 [details] [diff] [review]
enable Breakpad on Linux/ARM

This patch moved to bug 435575.
Attachment #435134 - Attachment is obsolete: true
(In reply to comment #10)
> Er, I dunno, the tinderbox Linux64 debug builds are just fine using this
> mozconfig:
> http://hg.mozilla.org/build/buildbot-configs/file/3ed8c28d1dcc/mozilla2/linux64/mozilla-central/debug/mozconfig
> 

I'll check it out.

> Are you sure it was this changeset? That error doesn't look like anything
> related to this.

Yeah, bisection fingered this patch.

> 
> FWIW, you can switch to -gdwarf-2 now if you want.

cool.
syncing the mozconfigs with buildbot's works. I think my problem was a use of  ac_cv_visibility_pragma=no instead of ac_cv_have_visibility_class_bug=yes. Thanks ted.
Comment on attachment 435133 [details] [diff] [review]
enable Breakpad on Linux/x86-64
[Checkin: Comment 8]

could we have that on the branch please as all the other crashreporter changes landed there already?
Attachment #435133 - Flags: approval1.9.2.4?
FWIW, this is a pretty trivial change and only impacts Linux/x86-64, which I don't think we're officially shipping on 1.9.2 (but Linux distros are).
Attachment #435133 - Attachment description: enable Breakpad on Linux/x86-64 → enable Breakpad on Linux/x86-64 [Checkin: Comment 8]
http://hg.mozilla.org/mozilla-central/rev/9707858ee63b
enable compiling Breakpad on Linux/ARM by default
Whiteboard: [first patch was fixed in mozilla1.9.3a4]
Target Milestone: mozilla1.9.3a4 → mozilla1.9.3a5
Uh, I split that out into a new bug, I don't think you need to note that here.
Blocks: 564166
Comment on attachment 435133 [details] [diff] [review]
enable Breakpad on Linux/x86-64
[Checkin: Comment 8]

This isn't going to make 1.9.2.4, but we can try for 1.9.2.5.
Attachment #435133 - Flags: approval1.9.2.4? → approval1.9.2.5?
Drivers: this patch has essentially zero impact on Firefox builds, since we don't ship Linux x86-64 releases from 1.9.2, but would make Linux distros happy. (Also the patch in bug 555674 is written on top of this patch.)
Attachment #435133 - Flags: approval1.9.2.5? → approval1.9.2.5+
Blocks: 608670
Blocks: 613419
No longer blocks: 608670
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.