Closed
Bug 555674
Opened 14 years ago
Closed 14 years ago
enable compiling Breakpad on Linux/ARM by default
Categories
(Firefox Build System :: General, defect)
Tracking
(status1.9.2 .5-fixed)
RESOLVED
FIXED
mozilla1.9.3a5
Tracking | Status | |
---|---|---|
status1.9.2 | --- | .5-fixed |
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(3 files, 1 obsolete file)
1.19 KB,
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
2.49 KB,
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
3.69 KB,
patch
|
pavlov
:
approval1.9.2.5+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #554021 +++ We should enable compiling Breakpad on Linux/ARM by default. Splitting this off to a separate bug because there are some issues we need to fix first, and the Linux/x86-64 patch in bug 554021 has already landed.
Assignee | ||
Updated•14 years ago
|
No longer blocks: support-L64, 554138
Assignee | ||
Comment 1•14 years ago
|
||
Carrying over jimb's r+ from bug 554021 comment 7.
Attachment #435575 -
Flags: review+
Assignee | ||
Comment 2•14 years ago
|
||
from bug 554021 comment 4: > After fixing a few minor things, I'm still hitting an internal compiler error > compiling in Scratchbox: > /home/cltbld/mozilla-central/toolkit/crashreporter/google-breakpad/src/common/linux/language.cc:76: > internal compiler error: in reference_to_unused, at dwarf2out.c:10094 We'll need to resolve this before we can land this patch.
Assignee | ||
Comment 3•14 years ago
|
||
I figured out a workaround, just filtering out -gwhatever from HOST_CXXFLAGS lets this compile just fine. I got Fennec on an N900 to produce a minidump, but it crashes after writing the dump, so I spent a bunch of time trying to track that down today.
Assignee | ||
Comment 4•14 years ago
|
||
Ok, this adds a workaround for the internal compiler error. We just skip generating debug info for some of the symbol dumping code. We don't need debug symbols for that anyway, so it shouldn't be a problem.
Attachment #435575 -
Attachment is obsolete: true
Attachment #437027 -
Flags: review?(jim)
Assignee | ||
Comment 5•14 years ago
|
||
This patch needs to be upstreamed as well. It contains some extraneous semicolon removal so we can compile with -pedantic, as well as a fix for a bug in the inline assembly implementation of sys_clone.
Attachment #437028 -
Flags: review?(jim)
Assignee | ||
Comment 6•14 years ago
|
||
With both of these patches applied I'm able to successfully crash Fennec on the N900 and get a working minidump + the crash reporter UI.
Updated•14 years ago
|
Attachment #437027 -
Flags: review?(jim) → review+
Updated•14 years ago
|
Attachment #437028 -
Flags: review?(jim) → review+
Assignee | ||
Comment 7•14 years ago
|
||
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/9707858ee63b http://hg.mozilla.org/mozilla-central/rev/8a97fc25da6f
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Assignee | ||
Comment 8•14 years ago
|
||
I landed the Breakpad fixup upstream: http://code.google.com/p/google-breakpad/source/detail?r=579
Assignee | ||
Comment 9•14 years ago
|
||
Drivers: we'd like to take this patch to enable crash reporting for Fennec Maemo builds on branch. These are ARM-only changes, should have no effect on Firefox. (This patch relies on bug 554021's patch as well.)
Attachment #446289 -
Flags: approval1.9.2.5?
Updated•14 years ago
|
Attachment #446289 -
Flags: approval1.9.2.5? → approval1.9.2.5+
Assignee | ||
Comment 10•14 years ago
|
||
Can you a+ the patch in bug 554021 as well? (This one applies on top of that one.)
Assignee | ||
Comment 11•14 years ago
|
||
Pushed to 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/fe0f13bfc4fb
status1.9.2:
--- → .5-fixed
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•