Closed Bug 554359 Opened 11 years ago Closed 11 years ago

about:rights text in nightlies is showing text for branded builds

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(thunderbird3.1 beta2-fixed)

RESOLVED FIXED
Thunderbird 3.1b2
Tracking Status
thunderbird3.1 --- beta2-fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #462598 +++

The about:rights page in nightly builds is showing the text that is intended for branded builds (ie, things called "Thunderbird").

We need to fix this and the best way is to port bug 514954 and do something similar to bug 462598.

I have a patch for this that I'm currently testing.
Attached patch The fixSplinter Review
This seems to fix it - I'm porting bug 514954 and adjusting the aboutRights.xhtml to take account of the better variable to use.
Attachment #434401 - Flags: review?
Attachment #434401 - Flags: review? → review?(bugspam.Callek)
Comment on attachment 434401 [details] [diff] [review]
The fix

Hmm, m-c doesn't do the DEFINES+= part of this anywhere, and they still "seem" to work. So I question our need for it (not-tested). But it doesn't hurt us either, so looks good enough to land.
Attachment #434401 - Flags: review?(bugspam.Callek) → review+
(In reply to comment #2)
> (From update of attachment 434401 [details] [diff] [review])
> Hmm, m-c doesn't do the DEFINES+= part of this anywhere, and they still "seem"
> to work. So I question our need for it (not-tested). But it doesn't hurt us
> either, so looks good enough to land.

Looks like you're correct, so I removed it (I think the AC_DEFINE in configure.in does it for us).

http://hg.mozilla.org/comm-central/rev/22a663de7b8f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
(In reply to comment #3)
> (I think the AC_DEFINE in configure.in does it for us).

Indeed it does.
Oh I forgot to say, I think automated testing for this would be difficult as you're basically checking the right text is displayed. Therefore I'd suggest we write a couple of simple litmus tests one for official builds and one for nightlies.
Flags: in-litmus?
Blocks: C192ConfSync
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.