Polish some icons in the main toolbar

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: phiw2, Assigned: phiw2)

Tracking

Details

Attachments

(3 attachments, 3 obsolete attachments)

3.08 KB, application/zip
alqahira
: review+
stuart.morgan+bugzilla
: superreview+
Details
3.32 KB, application/zip
alqahira
: review+
stuart.morgan+bugzilla
: superreview+
stuart.morgan+bugzilla
: feedback+
Details
4.28 KB, application/zip
alqahira
: review+
stuart.morgan+bugzilla
: superreview+
stuart.morgan+bugzilla
: feedback+
Details
(Assignee)

Description

9 years ago
see bug 524506 comment 0

* home icon
* reload icon
* dl_manager (match colour and shape to refreshed icon in Preferences window)
(Assignee)

Comment 1

9 years ago
Created attachment 436129 [details]
dl_manager.tiff v1.0

Matching the new arrow in the Preferences window.

In context:
http://dev.l-c-n.com/camino/toolbar/toolbar_v1.0-large.png
http://dev.l-c-n.com/camino/toolbar/toolbar_v1.0-small.png
Assignee: nobody → phiw
Status: NEW → ASSIGNED
Attachment #436129 - Flags: review?(alqahira)
(Assignee)

Comment 2

9 years ago
Created attachment 436130 [details]
home.tiff v1.0

Stuart is this in line with your wishes in bug 384725 comment 22 ?

> Two after-the-fact comments from actually using these; I'm not sure if there's
> any chance of additional tweaks:
...
> - The front step that was added to the house breaks the bottom line that it
> used to share with many other elements in the toolbar, and makes it more busy.
> Can we shave that off?
Attachment #436130 - Flags: feedback?(stuart.morgan+bugzilla)
(Assignee)

Comment 3

9 years ago
Created attachment 436131 [details]
reload.tiff v1.2

Trying to match the shape of the Camino 1.5 icon with the sharpness of the Camino 2.0 icon.

Stuart, same question as for the home icon:

> - The shape of the reload arrow was changed somewhat, and it now appears less
> round and more smooshed, which is really bothering me. Could we have the old
> shape with the new contrast?

Both the Home icon and the reload icon can be seen in context in the screenshots linked in comment 1
Attachment #436131 - Flags: feedback?(stuart.morgan+bugzilla)

Comment 4

9 years ago
Comment on attachment 436130 [details]
home.tiff v1.0

Hm, I guess I see why the step was there; the brown-directly-on-dark-grey of the bottom is not so good :(

Maybe the step should be set into the house, and the door a bit higher? Not sure how that would look.

Or maybe I just shouldn't worry about the step at all, since I don't think anyone else has complained ;)
Attachment #436130 - Flags: feedback?(stuart.morgan+bugzilla) → feedback-

Comment 5

9 years ago
Comment on attachment 436131 [details]
reload.tiff v1.2

The inner and outer curve don't seem to match here, so the swoop doesn't seem to get evenly thicker as it goes.
Attachment #436131 - Flags: feedback?(stuart.morgan+bugzilla) → feedback-
(Assignee)

Comment 6

9 years ago
(In reply to comment #4)
> (From update of attachment 436130 [details])
 
> Maybe the step should be set into the house, and the door a bit higher? Not
> sure how that would look.

I had made something like that:
http://dev.l-c-n.com/camino/toolbar/home_tx.png
(needs some fine tuning here and there...)
Dunno.
 
> Or maybe I just shouldn't worry about the step at all, since I don't think
> anyone else has complained ;)
Personally, it doesn't bother me.


(In reply to comment #5)
> (From update of attachment 436131 [details])
> The inner and outer curve don't seem to match here, so the swoop doesn't seem
> to get evenly thicker as it goes.

The swoop still needs some tuning. But if the overall shape is OK, we're on the way :-)
(the arrow tip is slightly lower than in the Camino2.0 icon, to match the Camino 1.5 icon)
(In reply to comment #4)
> Or maybe I just shouldn't worry about the step at all, since I don't think
> anyone else has complained ;)

It looks funny to me ;)
Comment on attachment 436129 [details]
dl_manager.tiff v1.0

This one looks fine to me.
Attachment #436129 - Flags: review?(alqahira) → review+
(Assignee)

Comment 9

9 years ago
Created attachment 438632 [details]
home v2

A compromise solution? The bright row of the step moved one 1px higher and is slightly darker.

In context
http://dev.l-c-n.com/camino/toolbar/toolbar_home_S.png
http://dev.l-c-n.com/camino/toolbar/toolbar_home_L.png
Attachment #436130 - Attachment is obsolete: true
Attachment #438632 - Flags: feedback?(stuart.morgan+bugzilla)
(Assignee)

Comment 10

9 years ago
Created attachment 438647 [details]
reload v2

Stuart, does this match your expectations more ?

In context:
http://dev.l-c-n.com/camino/toolbar/reload_v2_L.png
http://dev.l-c-n.com/camino/toolbar/reload_v2_S.png
Attachment #436131 - Attachment is obsolete: true
Attachment #438647 - Flags: feedback?(stuart.morgan+bugzilla)

Comment 11

9 years ago
Comment on attachment 438632 [details]
home v2

Looks good to me.
Attachment #438632 - Flags: feedback?(stuart.morgan+bugzilla) → feedback+

Comment 12

9 years ago
Comment on attachment 438647 [details]
reload v2

This is better than the last one, but the tapering still feels uneven to me. It feels abrupt in the bottom-to-left transition, and like it doesn't taper much at all in the tail.

Maybe I'm just staring at them so long that nothing looks right though.
(Assignee)

Updated

9 years ago
Attachment #438632 - Flags: review?(alqahira)
(Assignee)

Comment 13

9 years ago
Created attachment 440955 [details]
reload - v3

I think I got those curves about right now.

In context (including home icon):
http://dev.l-c-n.com/camino/toolbar/toolbar-3-L.png
http://dev.l-c-n.com/camino/toolbar/toolbar-3-S.png
Attachment #438647 - Attachment is obsolete: true
Attachment #440955 - Flags: review?(alqahira)
Attachment #438647 - Flags: feedback?(stuart.morgan+bugzilla)
Comment on attachment 440955 [details]
reload - v3

When Stuart's happy here, I'm happy.
Attachment #440955 - Flags: feedback?(stuart.morgan+bugzilla)

Comment 15

9 years ago
Comment on attachment 440955 [details]
reload - v3

Yep, this looks good. Thanks for your patience :)
Attachment #440955 - Flags: feedback?(stuart.morgan+bugzilla) → feedback+
Comment on attachment 438632 [details]
home v2

r=ardissone

We probably ought to have a rule that for UI images/icons, if an sr has f+ed the thing and someone else has r+ed it, there's no need for sr again, but since we have no such rule…. ;)
Attachment #438632 - Flags: superreview?(stuart.morgan+bugzilla)
Attachment #438632 - Flags: review?(alqahira)
Attachment #438632 - Flags: review+
Comment on attachment 440955 [details]
reload - v3

r=ardissone
Attachment #440955 - Flags: superreview?(stuart.morgan+bugzilla)
Attachment #440955 - Flags: review?(alqahira)
Attachment #440955 - Flags: review+
Comment on attachment 436129 [details]
dl_manager.tiff v1.0

Stuart, this one you had not been previously asked to f?
Attachment #436129 - Flags: superreview?(stuart.morgan+bugzilla)

Updated

9 years ago
Attachment #436129 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+

Comment 19

9 years ago
Comment on attachment 436129 [details]
dl_manager.tiff v1.0

sr=smorgan

Updated

9 years ago
Attachment #438632 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+

Updated

9 years ago
Attachment #440955 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
http://hg.mozilla.org/camino/rev/8b633b7ba1a9 and cvs trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.