555353 - Direct2D needs to clear the dirty area

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

Direct2D needs to clear the dirty area before having it drawn to. Other render modes do this by pushing a group and then popping it to source and painting with operator source.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Clear D2D dirty area before drawing.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Have you measured the performance cost of this? I guess we at least have an additional flush?

Comment 3

[Bas Schouten (:bas.schouten)]

(In reply to comment #2)
> Have you measured the performance cost of this? I guess we at least have an
> additional flush?

In the general case where we have a single rectangular clip rect it won't. With more complex clipping regions there will be some additional performance overhead.

Comment 4

[[not reading bugmail]]

Is this able to review?  I see its been in Jimm's que for a bit.

Comment 5

[redsign]

Do we Direct2D users have to wait another few weeks till we get this small but very important patch landed? Sorry for the spamming but I'm really getting impatient ...

Comment 6

[Bas Schouten (:bas.schouten)]

(In reply to comment #5)
> Do we Direct2D users have to wait another few weeks till we get this small but
> very important patch landed? Sorry for the spamming but I'm really getting
> impatient ...

Resolving the Aero glass problems also relies on bug 568495. I was planning on waiting for the r+ on that before landing it.

Comment 7

[redsign]

Oh yes I know that it relies on that one, too. But I did not know that you are waiting for that one to get the r+. Sorry for the rant and thank you for the good job. For me Direct2D is the best thing going on in the trunk besides the work for the new theme. It would be very cool to see that two advantages work together.

Comment 8

[Bas Schouten (:bas.schouten)]

Pushed http://hg.mozilla.org/mozilla-central/rev/1e9492c3f10f.