556027 - Allow setting an attribute to use Hardware layermanagers

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Bas Schouten (:bas.schouten)]

We need to allow setting an attribute on XUL windows in order to tell them to use a hardware layers manager. This will allow us to enable hardware acceleration on a per widget basis.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Part 1: Add boolean to nsWidgetInitData and deal with it in Widget

This patch adds a boolean to nsWidgetInitData to flag if a widget should use hardware layers. It will then try and create and initialize a LayerManagerOGL on that platform. If this fails to initialize it will fallback to a normal basic layer manager.

Other platforms should have their paint routines adapted to not always assume basic layer managers once we make the OGL initializations succeed there.

Sadly a large part of this patch is indentation depth changing in OnPaint on windows!

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+    } else if (GetLayerManager()->GetBackendType() ==
+               LayerManager::LAYERS_OPENGL) {
+      static_cast<mozilla::layers::LayerManagerOGL*>(GetLayerManager())->
+        SetClippingRegion(event.region);
+      result = DispatchWindowEvent(&event, eventStatus);
     }

Probably we should just switch on GetLayerManager()->GetBackendType(). There should be a "default" clause which does NS_ERROR.

How about mAcceleratedRendering instead of mUseHardwareLayers?

I think we should take this out of the initdata and just have a method SetAcceleratedRendering. Then we can switch dynamically if desired.

Comment 3

[Bas Schouten (:bas.schouten)]

Attachment: Part 1: Allow SetAcceleratedRendering on top level widgets

Updated to now have an AcceleratedRendering attribute. Setting this on child widgets is pointless, they will reset automatically to the parent widget setting.

Comment 4

[Bas Schouten (:bas.schouten)]

Attachment: Part 2: Add 'accelerated' attribute to nsXULWindow

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 436100 [details] [diff] [review]
Part 1: Allow SetAcceleratedRendering on top level widgets

+  GetNSWindowPtr(GetTopLevelHWND(mWnd, PR_TRUE))->
+    GetAcceleratedRendering(&useAcceleration);

Null-check the result of GetNSWindowPtr. In embedded situations this could be null when we don't own the toplevel window.

+      "AutoLayerManagerSetup instantiated for none basic layer backend!");

non-basic

+  NS_IMETHOD              GetAcceleratedRendering(PRBool *aEnabled);

Just make this virtual PRBool (returning the value directly)

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 436101 [details] [diff] [review]
Part 2: Add 'accelerated' attribute to nsXULWindow

+GK_ATOM(accelerated, "accelerated")

Don't add this, since we don't use it.

Comment 7

[Bas Schouten (:bas.schouten)]

Pushed https://bugzilla.mozilla.org/show_bug.cgi?id=556027.

Comment 8

[Bas Schouten (:bas.schouten)]

Pushed http://hg.mozilla.org/mozilla-central/rev/e58f14a89cc4.
Pushed http://hg.mozilla.org/mozilla-central/rev/413031db087e.

Comment 9

[Markus Stange [:mstange]]

Most other boolean XUL attributes work via case-sensitive comparison to "true", not via hasAttribute.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That's true, but the Web works differently ... anyway, it doesn't matter too much. This code is actually temporary because sooner or later all our windows will be accelerated.

Comment 11

[Eric Shepherd [:sheppy]]

Documented here:

https://developer.mozilla.org/en/XUL/Attribute/accelerated

With appropriate entry added to:

https://developer.mozilla.org/en/XUL/window