Extra resizer on some XUL dialogs

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ehsan, Assigned: Neil Deakin)

Tracking

({dev-doc-complete, regression})

Trunk
x86
Mac OS X
dev-doc-complete, regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 436587 [details]
Screenshot

See the attachment for a sample of the problem.  I _think_ that this is a regression from the textarea resizer addition.
It's a regression from setting -moz-appearance: resizer on resizers on Mac in bug 510333.
Blocks: 510333
No longer blocks: 167951
(Assignee)

Comment 2

7 years ago
Markus, so the Mac widget code is applying the native resizer by default, and the <resizer> in the cookies dialog is only needed for non-Mac?

Maybe we need to add a variation (say, type="window") that is hidden on Mac.
(In reply to comment #2)
> Markus, so the Mac widget code is applying the native resizer by default, and
> the <resizer> in the cookies dialog is only needed for non-Mac?

Correct.

> Maybe we need to add a variation (say, type="window") that is hidden on Mac.

Or we hide it by default and set class="textbox-resizer" on those inside textboxes and only show those.
(Assignee)

Comment 4

7 years ago
(In reply to comment #3)
> Or we hide it by default and set class="textbox-resizer" on those inside
> textboxes and only show those.

That wouldn't work for any other usage of <resizer> in a window.
Then maybe resizer[element] { ... }? I guess that still wouldn't work for resizers in panels... OK, type="window" is good.
(Assignee)

Comment 6

7 years ago
Created attachment 456074 [details] [diff] [review]
like so
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #456074 - Flags: review?(dao)
Comment on attachment 456074 [details] [diff] [review]
like so

Not good for cross-platform development, but I don't have a better suggestion.
Attachment #456074 - Flags: review?(dao) → review+

Updated

7 years ago
Keywords: dev-doc-needed
(Assignee)

Comment 8

7 years ago
http://hg.mozilla.org/mozilla-central/rev/7c7f74ecf1c6
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Documented: https://developer.mozilla.org/en/XUL/resizer

Let me know if this is wrong in any way.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.