Last Comment Bug 556645 - Extra resizer on some XUL dialogs
: Extra resizer on some XUL dialogs
Status: RESOLVED FIXED
: dev-doc-complete, regression
Product: Core
Classification: Components
Component: XUL (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Neil Deakin
:
Mentors:
Depends on:
Blocks: 510333
  Show dependency treegraph
 
Reported: 2010-04-01 16:10 PDT by :Ehsan Akhgari (busy, don't ask for review please)
Modified: 2010-10-15 07:46 PDT (History)
9 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Screenshot (29.72 KB, image/png)
2010-04-01 16:10 PDT, :Ehsan Akhgari (busy, don't ask for review please)
no flags Details
like so (2.62 KB, patch)
2010-07-05 11:12 PDT, Neil Deakin
dao+bmo: review+
Details | Diff | Review

Description :Ehsan Akhgari (busy, don't ask for review please) 2010-04-01 16:10:31 PDT
Created attachment 436587 [details]
Screenshot

See the attachment for a sample of the problem.  I _think_ that this is a regression from the textarea resizer addition.
Comment 1 Markus Stange [:mstange] 2010-04-03 09:27:45 PDT
It's a regression from setting -moz-appearance: resizer on resizers on Mac in bug 510333.
Comment 2 Neil Deakin 2010-04-09 07:19:22 PDT
Markus, so the Mac widget code is applying the native resizer by default, and the <resizer> in the cookies dialog is only needed for non-Mac?

Maybe we need to add a variation (say, type="window") that is hidden on Mac.
Comment 3 Markus Stange [:mstange] 2010-04-09 08:39:54 PDT
(In reply to comment #2)
> Markus, so the Mac widget code is applying the native resizer by default, and
> the <resizer> in the cookies dialog is only needed for non-Mac?

Correct.

> Maybe we need to add a variation (say, type="window") that is hidden on Mac.

Or we hide it by default and set class="textbox-resizer" on those inside textboxes and only show those.
Comment 4 Neil Deakin 2010-04-09 08:42:29 PDT
(In reply to comment #3)
> Or we hide it by default and set class="textbox-resizer" on those inside
> textboxes and only show those.

That wouldn't work for any other usage of <resizer> in a window.
Comment 5 Markus Stange [:mstange] 2010-04-09 08:49:22 PDT
Then maybe resizer[element] { ... }? I guess that still wouldn't work for resizers in panels... OK, type="window" is good.
Comment 6 Neil Deakin 2010-07-05 11:12:11 PDT
Created attachment 456074 [details] [diff] [review]
like so
Comment 7 Dão Gottwald [:dao] 2010-07-05 11:59:55 PDT
Comment on attachment 456074 [details] [diff] [review]
like so

Not good for cross-platform development, but I don't have a better suggestion.
Comment 9 Eric Shepherd [:sheppy] 2010-10-15 07:46:35 PDT
Documented: https://developer.mozilla.org/en/XUL/resizer

Let me know if this is wrong in any way.

Note You need to log in before you can comment on or make changes to this bug.