556645 - Extra resizer on some XUL dialogs

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[(no longer active)]

Attachment: Screenshot

See the attachment for a sample of the problem.  I _think_ that this is a regression from the textarea resizer addition.

Comment 1

[Markus Stange [:mstange]]

It's a regression from setting -moz-appearance: resizer on resizers on Mac in bug 510333.

Comment 2

[Neil Deakin]

Markus, so the Mac widget code is applying the native resizer by default, and the <resizer> in the cookies dialog is only needed for non-Mac?

Maybe we need to add a variation (say, type="window") that is hidden on Mac.

Comment 3

[Markus Stange [:mstange]]

(In reply to comment #2)
> Markus, so the Mac widget code is applying the native resizer by default, and
> the <resizer> in the cookies dialog is only needed for non-Mac?

Correct.

> Maybe we need to add a variation (say, type="window") that is hidden on Mac.

Or we hide it by default and set class="textbox-resizer" on those inside textboxes and only show those.

Comment 4

[Neil Deakin]

(In reply to comment #3)
> Or we hide it by default and set class="textbox-resizer" on those inside
> textboxes and only show those.

That wouldn't work for any other usage of <resizer> in a window.

Comment 5

[Markus Stange [:mstange]]

Then maybe resizer[element] { ... }? I guess that still wouldn't work for resizers in panels... OK, type="window" is good.

Comment 6

[Neil Deakin]

Attachment: like so

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 456074 [details] [diff] [review]
like so

Not good for cross-platform development, but I don't have a better suggestion.

Comment 8

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/7c7f74ecf1c6

Comment 9

[Eric Shepherd [:sheppy]]

Documented: https://developer.mozilla.org/en/XUL/resizer

Let me know if this is wrong in any way.