557030 - Copies & Folders can not be changed and the dialog box freezes its contents, after upgrade to Tb 3.0.4 from Tb 3.0.3 (Upgrade to Tb 3.0.4 generates mail.identity.idX.archive_folder=mailbox://nobody@smart%20mailboxes/Archives) [unified folders]

Status: RESOLVED INCOMPLETE

(Thunderbird :: Account Manager, defect)

Description

[Dmitri]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4

I have Copies and folders settings migrated from the previous version
of Thunderbird correctly. However, I am not able
to change them, nor I can not change those settings
for new accounts.

In addition, after visiting Copies and Folders screen the
dialog box content is not updated even when I select
a different section on the left or even move to a different
account settings. The latter happens
even if I do not attempt to change anything.

OK button appears to be enabled but has no effect.
Cancel button works.

The bug does not appear to be reproducible
if you have just 1 or 2 IMAP accounts.
I have 5 POP accounts and 1 IMAP account
configured.

Reproducible: Always

Steps to Reproduce:
Case 1:

1. Have several POP accounts configured with prior version of Thunderbird.
2. Upgrade to Thunderbird 3.x. I also added IMAP account at this point.
3. Open Tools/Account Settings dialog box.
4. Choose one of the accounts and select Copies & Folders
5. Choose another setting for this or another account.
6  Observe Copies & Folders still displayed on the right.
7. Click OK button. Even though it is depressed the dialog box
does not close.

Case 2:

1-4 same as case 1
5. Attempt to change one of the folders. I tried Sent folder changes.
6. Click OK button. Even though it is depressed, the dialog box
does not close.
7. The only way to close is either X or Cancel. Changes are not saved.
Actual Results:  
Unable to save changes in Copies & Folders.
Very annoying.

Comment 1

[Dmitri]

Attachment: Account Options after Copies & Folders selected

Comment 2

[Dmitri]

Attachment: Copies & Folders screen stays even though another tree node is selected

Comment 3

[WADA:World Anti-bad-Duping Agency]

> migrated from the previous version of Thunderbird

From Tb 2.0.x to Tb 3.0.4?

Problem like next is frequently reported after Tb3.0.
  If folder setting points wrong folder(folder of deleted account, folder of
  hidden account, ...), Copies&Folders aetting is not saved.   
It's because Tb3.0 doesn't accept "Save" if such condition which was generated by Tb2 exists. Problem is; no warning message for it. simply/silently rejects OK button.

Problem like bug 471344? Or problem like bug 535183? See also bug 536768 for Junk setting case.

Comment 4

[Dmitri]

Checked all of the folders. They are all valid and functional.
Messages are stored in them.

This still does not explain why the dialog box does not function
properly while navigating. See Case #1.

Comment 5

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #4)
> Checked all of the folders. They are all valid and functional.
> Messages are stored in them.

Checked what of all folders? How? Do you read and understand bugs I pointed?

As lowest level folder name only is shown at Copies&Folders UI, shown "Drafts" doesn't always mean root-level Drafts folder. And as account name is not shown at Others: of Copies&Folders UI, screen shot never explains about which account's "Draft" or "xxx/Drafts" or "xxx/yyy/Drafts" is selected.
And, as "Archives Folders on: Smart Folders" is seen in your screen shot, it looks that same phenomenon as bug 535183 is involved in your case.

Comment 6

[WADA:World Anti-bad-Duping Agency]

As prefs.js data was not provided by opener of bug 535183, I closed bug 535183 as INCONPLETE(there was no way to do further analysis).
Dmitri, please keep backup of prefs.js first, and check Copies&Folders settings in prefs.js. Config Editor(Tool/Options/Adanced/General) can be used for your checking.

Comment 7

[Dmitri]

(In reply to comment #5)
> 
> Checked what of all folders? How?

Once I did it via Config Editor using "folder" filter.
Another time just inspected visually prefs.js

I found only one problem Local Folders/Templates were absent and was
referred to in one of the POP accounts.
This did not have any effect on the behavior.

> As lowest level folder name only is shown at Copies&Folders UI, shown "Drafts"
> doesn't always mean root-level Drafts folder. And as account name is not shown
> at Others: of Copies&Folders UI, screen shot never explains about which
> account's "Draft" or "xxx/Drafts" or "xxx/yyy/Drafts" is selected.

True. In fact, prior to migration all I had is Local Folders. After the migration you can see on the screen shot instead of say "Sent" on Local Folders,
it selects "Other" and where it points one can find only from config inspection.


> And, as "Archives Folders on: Smart Folders" is seen in your screen shot, it
> looks that same phenomenon as bug 535183 is involved in your case.


It looks the same.  *All* of my POP accounts "Archive" setting (and only Archive setting) after migration pointed to smart folders Archive.

My Gmail IMAP account works flawlessly ( was created after migration).

I did not change a single thing. In fact I could not change it after
the migration.

From  bug 535183 it looks like Smart Folders should be replaced in config to Local Folders to solve the problem. Am I correct?

Comment 8

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #7)
> From  bug 535183 it looks like Smart Folders should be replaced in config to
> Local Folders to solve the problem. Am I correct?

I think you are correct, but I'm not sure, because user can set "Smart Folders" as name of valid POP3 or IMAP account, even if you say "you never tourched settings", until I see prefs.js content :-)

I guess that "Archives Folders on: Smart Folders" in your case & bug 535183 is similar phenomenon to bug 534382 : a server entry for "Local Folders" was changed to server entry for hidden "Smart Folders" upon first upgrade to Tb 3.0.x, due to garbages(duplicated entries generated by Tb 2 or former) in prefs.js.
Please keep backup of prefs.js.

> In fact I could not change it after the migration.

Does it mean that next is imposiible?
  Re-select Archives of "Local Folders" at folder selection UI.
  In selection list, "Smart Folders"(hidden account) is not displayed.
Or it's possible but change is not saved? "Smart Folders" is always displayed even though "OK" button looks to save change?
If latter, it may be similar phenomenon to bug 472959 and bug 536768 (Junk setting case).

Please modify setting via Config Editor, and restart Tb to avoind unwanted problem.

Comment 9

[Dmitri]

(In reply to comment #8)
> (In reply to comment #7)

> I think you are correct, but I'm not sure, because user can set "Smart Folders"
> as name of valid POP3 or IMAP account, even if you say "you never tourched
> settings", until I see prefs.js content :-)

I considered attaching to the bug report my current copy of prefs.js.
However, after review I decided not to do so for privacy reasons.

Blanking out sensitive data would likely to
erase things you might be interested in.

For the same reason, you are unlikely to receive it
from others. If I am permitted to express MHO
you have enough information to build debugging
theories and come up with ways to test them. Just
my 2 cents.

If account names and "smartFolders" reside in the
same namespace it is highly likely to present a problem
which needs to be addressed.

> Please keep backup of prefs.js

I do. As matter of fact, I just found
a backup of Thunderbird data just prior
to the upgrade. That includes prefs.js.

I have produced a diff -u which I again
hesitate to post here. However, I may be
able to post some of it and answer your questions.


> Does it mean that next is imposiible?
>   Re-select Archives of "Local Folders" at folder selection UI.
> In selection list, "Smart Folders"(hidden account) is not displayed.
> Or it's possible but change is not saved? "Smart Folders" is always
> displayed even though "OK" button looks to save change?

I just looked at the top account
and I see SmartFolders as a selection for Archives.
I was able to switch back to LocalFolders and this
account configuration became functional.

"SmartFolders" though is not on the drop-down list among
the folders.

As a result I was able to change other settings in Copies & Folders
which I was not able to change before.

However, I was not able to change the next account.
I closed the dialog box.

Opened it again. This time I was able to change this account
too.

There are even more amazing things happening next. I am not
even sure you will believe me.

The next account also had a setting pointing archives smart Folders.
However, I did not change it but simply switched back on the left
the previous account Copies & Folders. It permitted me to do so.
Then I switched back where I expected to see smart Folders ( I did not
fix it). They were already fixed. Archive setting pointing to
Local Folders.

At first, I though I made a mistake. However, the same story
happened to the next account and then one more.

All I had to do then is to switch everything back to local
and things started working. 

I do not know what to say. On one hand I definitely missed 
some things. Did not look at the Archive setting
even after seeing it in the prefs. On the other
hand, what I just saw, scare me.

So I have a copy of faulty prefs.js. I should be able to play again.

Comment 10

[Dmitri]

Attachment: Diff between broken and fixed prefs.js

Submitting what's changed after things got fixed.
I blanked out names and email accounts.

I guess the only reason why I could not do it before
is that I never tried. I never change Templates or Drafts
and I was never looking there.

What I tried to change most of the time was "Sent"
because this is what I care about. And that simply
did not work.

Comment 11

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #10)
> Diff between broken and fixed prefs.js

Following is seen for id1,id2,id3,id4,id5,id6(some are subset of next).
> -user_pref("mail.identity.idX.archive_folder", "mailbox://nobody@smart%20mailboxes/Archives");
>  +user_pref("mail.identity.idX.archive_folder", "mailbox://nobody@Local%20Folders/Archives");
> -user_pref("mail.identity.idX.drafts_folder_picker_mode", "1");
> +user_pref("mail.identity.idX.drafts_folder_picker_mode", "0");
> -user_pref("mail.identity.idX.fcc_folder_picker_mode", "1");
> +user_pref("mail.identity.idX.fcc_folder_picker_mode", "0");
> -user_pref("mail.identity.idX.tmpl_folder_picker_mode", "1");
> +user_pref("mail.identity.idX.tmpl_folder_picker_mode", "0");

It looks that your case is fortunately corruption of xxx_folder only.

> I guess the only reason why I could not do it before is that I never tried.
> I never change Templates or Drafts and I was never looking there.

I think you are right. Recovery from Copies&Folders UI only is possible - re-select all folders via UI.

Probably due to "remove of duplicated account/server by Tb 3.0.x". It's similar problem to bug 534382. Difference is : victim/affected/corrupted entry in prefs.js.
As affected entries was folder setting which points folder of "Local Folders" only, I think duplicated entry was server entry of same property as "Local Folders".(serverX.type=none, serverX.hostname;Local Folders, or smart mailboxes if you used prefs.js with Tb3.0beta before upgrade, serverX.userName=nobody).
Can you check diff of "backup before upgrade" and "backup after upgrade(corrupted)"?

Comment 12

[WADA:World Anti-bad-Duping Agency]

"forunately" means that you didn't experience problem such as bug 505465, Bug 534382, bug 543252 upon upgrade, probably because you upgraded to Tb 3.0.4.

Comment 14

[WADA:World Anti-bad-Duping Agency]

Attachment: prefs.js entries to check relation among account/server/identity and folder selection settings

This is list of prefs.js entry needed to check "duplicated accounts/servers".

Comment 15

[Dmitri]

(In reply to comment #11)
> As affected entries was folder setting which points folder of "Local Folders"
> only, I think duplicated entry was server entry of same property as "Local
> Folders".

Agree. I was about to comment the same.

> (serverX.type=none, serverX.hostname;Local Folders, or smart mailboxes
> if you used prefs.js with Tb3.0beta before upgrade, serverX.userName=nobody).
> Can you check diff of "backup before upgrade" and "backup after
> upgrade(corrupted)"?

Although I do have back up just prior to upgrade I do not have one
immediately after upgrade.  I usually run incremental backups
but do not store intermediates. This was a special case.
I can try to produce a diff between the corrupted and
the one just prior to upgrade for what is worth.

(In reply to comment #12)
> "forunately" means that you didn't experience problem such as bug 505465, Bug
> 534382, bug 543252 upon upgrade, probably because you upgraded to Tb 3.0.4.

I did not upgrade straight to 3.0.4. I went through all upgrades starting
3.0.0.

Comment 16

[Dmitri]

Attachment: Diff between prior to upgrade and the broken one

Blanked out personal info

Comment 17

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #15)
> I did not upgrade straight to 3.0.4. I went through all upgrades starting
3.0.0.
(In reply to comment #16)
> Diff between prior to upgrade and the broken one

> -user_pref("mail.server.server7.hostname", "Local Folders");
> -user_pref("mail.server.server7.name", "Local Folders");
> +user_pref("mail.server.server7.directory", "####");
> +user_pref("mail.server.server7.directory-rel", "[ProfD]Mail/Local Folders-1");
> +user_pref("mail.server.server7.hidden", true);
> +user_pref("mail.server.server7.hostname", "smart mailboxes");
> +user_pref("mail.server.server7.name", "Smart Folders");
>  user_pref("mail.server.server7.type", "none");
>  user_pref("mail.server.server7.userName", "nobody");

Following garbage looks to have remaind after Tb2 -> 3.0.0 -> 3.0.1 -> 3.0.2 -> 3.0.3. It generated "duplicated server entries" condition.
> server7.name=Local Folders (=> altered to "Smart Folders" after upgrade to Tb 3.0.4)
> server7.hostname=Local Folders, server7.userName=nobody, server7.type=none

server7.hostname="Local Folders" prior to upgrade to Tb 3.0.4 seems bug 505465.
(server2.name=Local Folders, accountmanager.localfoldersserver=server2 exists)
Directory of [ProfD]Mail/Local Folders-1(in server7.directory-rel) was same phenomenon as Bug 534382. As account2/server2 for original Local Folders was fortunately not damaged in your case(affected one, changed to  Smart Folders, was server7 in your case), problem like Bug 534382 was not exposed. 

As server7.hostname="smart mailboxes" is seen in corrupted prefs.js only(prefs.js after upgrade to 3.0.4 only), it looks that you didn't use "Smart Folders" view. If you used "Smart Folders" view, I guess you experienced this bug's problem earlier. (bug 535183 is report of problem atter Tb2 -> Tb 3.0.0)

As directory name of "Local Folders-1" is used for server7.hostname="smart mailboxes", it may produce confusion. I recommend you to do next.
(1) delete mail.server.server7.directory, mail.server.server7.directory-rel
    from prefs.js, and restart Tb.
(2) Use "Smart Folders" view at folder pane. Mail/smart mailboxes is created.
    Change back to "All Folders" view.
(3) Delete directory of [ProfD]Mail/Local Folders-1.

Comment 18

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #16)
> Diff between prior to upgrade and the broken one
(In reply to comment #7)
I found only one problem Local Folders/Templates were absent and was referred to in one of the POP accounts.

For folder_picker_mode=1.

> +user_pref("mail.identity.id3.stationery_folder", "mailbox://nobody@Local%20Folders/Templates");
> user_pref("mail.identity.id3.tmpl_folder_picker_mode", "1");

(Problem-1, before upgrade to Tb 3.0.4)
idX.xxx_folder_picker_mode=1 was set before upgrade to Tb 3.0.4, but idX.xxx_folder didn't exist even though folder_picker_mode=1(corresponds to Others: at Copies&Folders UI).
(Problem-2, after upgrade to Tb 3.0.4)
As idX.xxx_folder doesn't exist even though folder_picker_mode=1, Tb 3.0.4 created idX.xxx_folder using "xxx of Local Folders", without existence check of folder because it's not folder selected by you via folder selection UI.
(Problem-3: Known issue occurs)
As Templates folder of "Local Folders" doesn't exist in your case even though tmpl_folder_picker_mode=1, Copies&Folder UI doesn't close normally, with no warning message, with no indication of inconsistency.
It's slightly different but similar situation to "delete of Template & Templates.msf while Tb is running or after termination of Tb". (Note: once selected as template, delete folder at UI is impossible).

Comment 19

[Dmitri]

Just want to make sure that nothing more is required of me.
My understanding that the problem was in the migration code.
Hope this was helpful.

Comment 20

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #19)
> Just want to make sure that nothing more is required of me.

Your two diff's is sufficient and most valuable data. No additional data is required currently. But other settings not listed in diff may be required in future for efficient duplication test. Please keep backup of three versions of prefs.js.
Thanks for your backing up of prefs.js.

Comment 21

[WADA:World Anti-bad-Duping Agency]

Bug 472959 and bug 536768 is same phenomenon on "Junk Settings".
This bug and bug 536768 looks produced by migration(by removing of duplicated account/server upon migration).
xref bug 536768 for ease of search nd tracking.

Comment 22

[:aceman]

Is this problem still existent? I tried it now in TB13. I changed "mail.identity.id1.archive_folder" in prefs.js manually to invalid values and when going to Copies & Folders I at first notices the invalid value in a field but at next visit to the pane or just pressing OK the values were sanitized and made valid (some default). The new values were stored to prefs.js. It look like somebody already implemented the sanitization in the same way as in bug 472959.

WADA, can you try it?

Comment 24

[:aceman]

If there is still a problem with deferred accounts (global inbox) I hope to fix it with the infrastructure developed in bug 536768.

Comment 25

[:aceman]

So can anybody still reproduce this problem on the Copies & Folders pane?

While it would probably be hard to test this on TB2 -> TB3, but we can at least check if pointing a folder (Sent, Archive, Drafts, Templates) to another account and then deleting/deferring that account.

Comment 26

[:aceman]

Bug 536768 is fixed now, can we move here in any way?

Comment 27

[Phoenix]

Resolved per whiteboard