558456 - Mac, OOPP Flash Video hangs in full screen mode

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Marcia Knous [:marcia]]

Seen while running Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a4) Gecko/20100407 MozillaDeveloperPreview/3.7a4

STR:
1. Load the site in the URL.
2. Press the full screen button on the video toolbar
3. Beachball

I eventually have to force quit the browser. The same video plays fine in full screen mode on the same machine using Chrome and Firefox 3.6.3.

Unfortunately because I have to kill the process, I crash in the same stack as in Bug 557011

Comment 1

[Marcia Knous [:marcia]]

The same video plays fine on my Windows 7 machine running the latest trunk nightly.

Comment 2

[Marcia Knous [:marcia]]

Happens on other sites as well that use flash, such as http://www.youtube.com/watch?v=G-nNHmh7Ick&feature=popular

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Does this work with the newest version of Flash 10.1 from http://labs.adobe.com/flashplayer ?

--> Core::IPC and cc'ing joshmoz and BenWa

Comment 4

[Benjamin Smedberg]

Please keep plugin bugs in Core:Plug-Ins, even if they are OOPP-only.

Comment 5

[Benoit Girard (:BenWa)]

Here are the relevant error log:

-1340583936[41013f0]: virtual bool mozilla::plugins::PluginInstanceChild::AnswerNPP_HandleEvent(const mozilla::plugins::NPRemoteEvent&, int16_t*) <--- (Presumably the fullscreen press)
-1340583936[41013f0]: void mozilla::plugins::child::_invalidaterect(NPP_t*, NPRect*)
-1598675744[400b8c0]: NPN_InvalidateRect: npp=20ebab40, top=45, left=0, bottom=315, right=640
Wed Apr 21 21:00:01 wavicle-2.local plugin-container[68890] <Error>: unknown error code: invalid context
Wed Apr 21 21:00:01 wavicle-2.local plugin-container[68890] <Error>: kCGErrorFailure: Set a breakpoint @ CGErrorBreakpoint() to catch errors as they are logged.
2010-04-21 21:00:01.959 plugin-container[68890:2b03] Warning once: This application, or a library it uses, is using NSQuickDrawView, which has been deprecated. Apps should cease use of QuickDraw and move to Quartz.
Wed Apr 21 21:00:02 wavicle-2.local plugin-container[68890] <Error>: kCGErrorIllegalArgument: CGSOrderWindowList
-1340583936[41013f0]: static NPUTF8* mozilla::plugins::PluginModuleChild::NPN_UTF8FromIdentifier(void*)
String: nodeType
-1340583936[41013f0]: void mozilla::plugins::child::_memfree(void*)
-1340583936[41013f0]: static NPUTF8* mozilla::plugins::PluginModuleChild::NPN_UTF8FromIdentifier(void*)
String: nodeType
-1340583936[41013f0]: void mozilla::plugins::child::_memfree(void*)
-1340583936[41013f0]: static NPUTF8* mozilla::plugins::PluginModuleChild::NPN_UTF8FromIdentifier(void*)
String: tagName
-1340583936[41013f0]: void mozilla::plugins::child::_memfree(void*)
[...]

I believe the relevant error is: kCGErrorIllegalArgument: CGSOrderWindowList

I noticed that pressing ESC restores everything correctly.

Comment 6

[Benoit Girard (:BenWa)]

Here is the stack trace by setting a breakpoint in CGErrorBreakpoint() for:
<Error>:
kCGErrorIllegalArgument: CGSOrderWindowList

Stacktrace:
#0  0x9392c642 in CGErrorBreakpoint ()
#1  0x939c1d88 in CGSGlobalErrorv ()
#2  0x95c7f9fc in HideMenuBarWindow ()
#3  0x95c7fbb8 in HideBar ()
#4  0x95aa4204 in SetSystemUIMode ()
#5  0x95c80184 in HideMenuBar ()
#6  0x06a09f5e in main ()
#7  0x06a10c9a in main ()
#8  0x0659b26f in draw_list ()
#9  0x068a0664 in draw_list ()
#10 0x068a233c in draw_list ()
#11 0x0686cfbf in draw_list ()
#12 0x067bbcc6 in draw_list ()
#13 0x067c1c2a in draw_list ()
#14 0x0659cd79 in draw_list ()
#15 0x068a0664 in draw_list ()
#16 0x067c15b8 in draw_list ()
#17 0x0659cd79 in draw_list ()
#18 0x068a0664 in draw_list ()
#19 0x067c15b8 in draw_list ()
#20 0x067bf2c7 in draw_list ()
#21 0x06995ba0 in unregister_ShockwaveFlash ()
#22 0x069964c2 in unregister_ShockwaveFlash ()
#23 0x06a15ed8 in main ()
#24 0x0698aa7a in FlashPlayer_10_1_53_21_FlashPlayer ()
#25 0x0126e094 in mozilla::plugins::PluginInstanceChild::AnswerNPP_HandleEvent (this=0x4023620, event=@0xb0183cb4, handled=0xb0183e26) at /Users/mozilla/mozilla/mozilla-central/dom/plugins/PluginInstanceChild.cpp:562
#26 0x01307212 in mozilla::plugins::PPluginInstanceChild::OnCallReceived (this=0x4023620, msg=@0xb018402c, reply=@0xb0183f8c) at PPluginInstanceChild.cpp:1304

(attaching full stracktrace)

Comment 7

[Benoit Girard (:BenWa)]

Attachment: Stacktrace

Comment 8

[Benoit Girard (:BenWa)]

I wonder if the problem is that the call is not done from thread 0 but thread 3 instead. If someone can confirm this then this bug should depend on bug 528146.

Comment 9

[Marcia Knous [:marcia]]

I filed another bug yesterday which may be a dupe of this bug, and https://bugzilla.mozilla.org/show_bug.cgi?id=560960#c3 indicates that there may be an issue with hardware acceleration. But unfortunately in the newest version of flash I cannot even access the context menu to change any settings because nothing happens when I right click. This is using the RC2 candidate on labs.adobe.com.

Comment 10

[Benoit Girard (:BenWa)]

I worked on a patch for bug 528146 to test my theory in comment #8 and it fixes this problem. We just have wait for a patch to land.

Comment 11

[Henri Sivonen (:hsivonen)]

Attachment: Crsh report with CA-enabled nightly, attempting to exist full screen on YouTube after going to full screen beachballs

Now that CoreAnimation is enabled, I see a different stack.

Comment 12

[Benoit Girard (:BenWa)]

You are correct, the stack posted above was incorrect. With the upcoming patch for bug 528146 the menu bar does not hide itself.

Comment 13

[Benoit Girard (:BenWa)]

Works for me after bug 528146 landed. Josh confirmed over IRC that this was working for him as well. Marking as fix.