558627 - [D2D]Re-painting is not performed properly when page is scrolling

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Alice0775 White]

Attachment: screenshot

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100410 Minefield/3.7a5pre ID:20100410035858
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100410 Minefield/3.7a5pre ID:20100410035858

Enabled D2D/DW, when I scrolled the  overlapped window , Re-painting is not performed properly.

C2Q@2.5Ghz, ATI Radeon HD4350, Windows7 home premium 64bit.

Reproducible: Always

Steps to Reproduce:
1. Start Minefield with D2D/DW enabled profile
2. Run Windows Task manager and makes it show up in front of other applications.
3. Let those windows overlap
4. scroll web page by mouse wheel and/or by using scroll bar. 

Actual Results:
 Re-painting is not performed properly

Expected Results:
 Re-painting should be performed properly

Comment 1

[Bas Schouten (:bas.schouten)]

This appears to be with Aero disabled, is that correct?

Comment 2

[Alice0775 White]

(In reply to comment #1)
> This appears to be with Aero disabled, is that correct?

Yes. Windows Classic Visul Style.

Comment 3

[Bas Schouten (:bas.schouten)]

(In reply to comment #2)
> (In reply to comment #1)
> > This appears to be with Aero disabled, is that correct?
> 
> Yes. Windows Classic Visul Style.

Desktop composition is on though? (i.e. the DWM is running)

I cannot reproduce this.

Comment 4

[Alice0775 White]

(In reply to comment #3)
> (In reply to comment #2)
> Desktop composition is on though? (i.e. the DWM is running)
> 
> I cannot reproduce this.
No, Desktop composition is unchecked(off) in the performance option dialog.

Comment 5

[Bas Schouten (:bas.schouten)]

Interesting, could you see if you can repro with it on?

Comment 6

[Alice0775 White]

(In reply to comment #5)
> Interesting, could you see if you can repro with it on?

I can not turn on Desktop composition.
Because it is turned off automatically. I think that this behavior is windows default.

Comment 7

[Alice0775 White]

>Because it is turned off automatically. I think that this behavior is windows default.
Because it is turned off automatically. I think that this behavior is windows default when I chose Windows Classic Theme.

Comment 8

[Bas Schouten (:bas.schouten)]

I can reproduce this with the classic theme. What I believe is happening is that we don't draw the part under the TaskManager when running the classic theme. When we proceed to scroll that part into view ScrollWindowEx would normally know this and invalidate it even though it scrolled into view.

The D2D scrolling code is not taking this into account. We need to modify the scroll functions to somehow realize that this part that is scrolled into view above the covering window still needs to be invalidated! (I can think of ways to do this, but they're not pretty, hopefully someone has a good idea!)

Comment 9

[Bas Schouten (:bas.schouten)]

Attachment: Properly update parts inside system clipping region

This patch will ensure we invalidate any parts scrolled into view from the system clipping region (i.e. parts occluded by other windows when desktop composition is off). This -should- also take care of the odd row of pixels when using different DPIs, but since I can no longer reproduce that problem (our window layout changed), I can't be 100% sure. We need to keep an eye on it though if anybody sees that bug reappearing (bug 548935).

Comment 10

[[e-mail]]

Comment on attachment 451325 [details] [diff] [review]
Properly update parts inside system clipping region

While the patch looks eminently reasonable, none of my build machines are currently configured to be able to build D2D...

Comment 11

[Rob Arnold [:robarnold]]

Comment on attachment 451325 [details] [diff] [review]
Properly update parts inside system clipping region

This appears to fix the scrolling issues.

Comment 12

[Bas Schouten (:bas.schouten)]

Pushed http://hg.mozilla.org/mozilla-central/rev/70230bd69c0b.