559500 - On about:support, "Open Containing Folder" is misleading

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[Jesse Ruderman]

On Windows, about:support contains

    Profile Directory    [[Open Containing Folder]]

This button doesn't open the folder that *contains* the profile; it's opening the profile folder itself.  So "Open Folder" would be more accurate.

On Mac, it's "Show in Finder", so I support "Show in Windows Explorer" could work as well.

Comment 1

[:aceman]

If this is just string change, I could do it.
But I am not sure about this. What is the difference between "Profile" and "Profile folder"? It seems for normal users it is the same. Are you arguing that "containing folder" is actually the ".../profiles/" parent folder? I am not sure.

Comment 2

[:aceman]

Attachment: fix

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 582710 [details] [diff] [review]
fix

I'd go with just "Explorer" rather than "Windows Explorer".

You'll need to update the reference to "aboutSupport.show.label" in the L10N notes as well.

Comment 4

[Justin Dolske [:Dolske]]

I know OS X uses "Show In Finder" in various places in its own UI (eg, right-click any icon in the Dock, under Options). But I'm not sure if Windows (or Windows apps) commonly use that kind of phrasing... Ask UX? "Open Folder" would also remove any unfortunate confusion from their browser also being called, in part, "Explorer".

Comment 5

[:aceman]

Yes, I put uiwanted in the keywords:)

I implemented the original proposal, on top of it I fixed Folder to Directory on Unix to match wording per bug 559500.

I have no problem dropping Explorer and leaving "Open Folder" on Win.

Comment 6

[:aceman]

Attachment: v2

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 584061 [details] [diff] [review]
v2

Thanks aceman, sorry for the review delay.

Comment 8

[:aceman]

I think this will break Thunderbird about:support so do not checkin yet. I'll prepare the corresponding patch.

Comment 9

[:aceman]

Attachment: corresponding update for TB

Comment 10

[:aceman]

Attachment: unbitrotting of v2 due to bug 631909

Carrying over review=gavin.sharp .

Comment 11

[Mark Banner (:standard8)]

Checked both patches in:

https://hg.mozilla.org/mozilla-central/rev/04d19214f561
http://hg.mozilla.org/comm-central/rev/c319515fbc60

Comment 12

[Ton [:Tonnes]]

>> -<!ENTITY aboutSupport.show.label "Open Containing Folder">
>> +<!ENTITY aboutSupport.showDir.label "Open Directory">
>> 
>> <!ENTITY aboutSupport.showMac.label "Show in Finder">
>> +<!-- LOCALIZATION NOTE (aboutSupport.showWin.label): This is the Windows-specific
>> +variant of aboutSupport.showDir.label. -->
>> +<!ENTITY aboutSupport.showWin.label "Show Folder">

Why was "Show Folder" chosen for Windows instead of "Open Folder" as suggested and mentioned above by 2?

"Show Folder" for Windows is the exception now and implies showing the folder (name) instead of its contents, as it was before this bug when it said "Open containing folder" for both Windows and Linux. "Show folder" is basically similar to "Open containing folder", which is what the bug was trying to avoid. Hence only "Open folder" (or "Show _in_ folder" / "Show folder content", both not preferred) would be accurate.

Comment 13

[Ton [:Tonnes]]

Any opinions? New bug required?

Comment 14

[Jesse Ruderman]

Ton, I don't have an opinion, but I do recommend filing a new bug. ("Clone" is the fastest way.)