On about:support, "Open Containing Folder" is misleading

VERIFIED FIXED in mozilla12

Status

()

VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: jruderman, Assigned: aceman)

Tracking

(Blocks: 1 bug, {polish, uiwanted})

Trunk
mozilla12
x86
Windows 7
polish, uiwanted
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

9 years ago
On Windows, about:support contains

    Profile Directory    [[Open Containing Folder]]

This button doesn't open the folder that *contains* the profile; it's opening the profile folder itself.  So "Open Folder" would be more accurate.

On Mac, it's "Show in Finder", so I support "Show in Windows Explorer" could work as well.
(Assignee)

Comment 1

7 years ago
If this is just string change, I could do it.
But I am not sure about this. What is the difference between "Profile" and "Profile folder"? It seems for normal users it is the same. Are you arguing that "containing folder" is actually the ".../profiles/" parent folder? I am not sure.
Assignee: nobody → acelists
Keywords: uiwanted
(Assignee)

Updated

7 years ago
Assignee: acelists → nobody
Component: General → General
Product: Firefox → Toolkit
QA Contact: general → general
(Assignee)

Updated

7 years ago
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Keywords: polish
(Assignee)

Comment 2

7 years ago
Created attachment 582710 [details] [diff] [review]
fix
Attachment #582710 - Flags: review?(benjamin)
(Assignee)

Updated

7 years ago
Blocks: 559501

Updated

7 years ago
Attachment #582710 - Flags: review?(benjamin) → review?(gavin.sharp)
Comment on attachment 582710 [details] [diff] [review]
fix

I'd go with just "Explorer" rather than "Windows Explorer".

You'll need to update the reference to "aboutSupport.show.label" in the L10N notes as well.
Attachment #582710 - Flags: review?(gavin.sharp) → review-
I know OS X uses "Show In Finder" in various places in its own UI (eg, right-click any icon in the Dock, under Options). But I'm not sure if Windows (or Windows apps) commonly use that kind of phrasing... Ask UX? "Open Folder" would also remove any unfortunate confusion from their browser also being called, in part, "Explorer".
(Assignee)

Comment 5

7 years ago
Yes, I put uiwanted in the keywords:)

I implemented the original proposal, on top of it I fixed Folder to Directory on Unix to match wording per bug 559500.

I have no problem dropping Explorer and leaving "Open Folder" on Win.
(Assignee)

Comment 6

7 years ago
Created attachment 584061 [details] [diff] [review]
v2
Attachment #582710 - Attachment is obsolete: true
Attachment #584061 - Flags: review?(gavin.sharp)
Comment on attachment 584061 [details] [diff] [review]
v2

Thanks aceman, sorry for the review delay.
Attachment #584061 - Flags: review?(gavin.sharp) → review+
Keywords: checkin-needed
(Assignee)

Comment 8

7 years ago
I think this will break Thunderbird about:support so do not checkin yet. I'll prepare the corresponding patch.
Keywords: checkin-needed
(Assignee)

Comment 9

7 years ago
Created attachment 586413 [details] [diff] [review]
corresponding update for TB
Attachment #586413 - Flags: review?(mbanner)
(Assignee)

Updated

7 years ago
Blocks: 631909

Updated

7 years ago
No longer blocks: 631909
(Assignee)

Comment 10

7 years ago
Created attachment 588136 [details] [diff] [review]
unbitrotting of v2 due to bug 631909

Carrying over review=gavin.sharp .
Attachment #584061 - Attachment is obsolete: true
Attachment #588136 - Flags: review+
(Assignee)

Updated

7 years ago
Depends on: 631909
Attachment #586413 - Flags: review?(mbanner) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Whiteboard: [must checkin both patches simultenously]
Checked both patches in:

https://hg.mozilla.org/mozilla-central/rev/04d19214f561
http://hg.mozilla.org/comm-central/rev/c319515fbc60
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [must checkin both patches simultenously]
Target Milestone: --- → mozilla12

Updated

7 years ago
Blocks: 725971
(Assignee)

Updated

7 years ago
Status: RESOLVED → VERIFIED

Comment 12

4 years ago
>> -<!ENTITY aboutSupport.show.label "Open Containing Folder">
>> +<!ENTITY aboutSupport.showDir.label "Open Directory">
>> 
>> <!ENTITY aboutSupport.showMac.label "Show in Finder">
>> +<!-- LOCALIZATION NOTE (aboutSupport.showWin.label): This is the Windows-specific
>> +variant of aboutSupport.showDir.label. -->
>> +<!ENTITY aboutSupport.showWin.label "Show Folder">

Why was "Show Folder" chosen for Windows instead of "Open Folder" as suggested and mentioned above by 2?

"Show Folder" for Windows is the exception now and implies showing the folder (name) instead of its contents, as it was before this bug when it said "Open containing folder" for both Windows and Linux. "Show folder" is basically similar to "Open containing folder", which is what the bug was trying to avoid. Hence only "Open folder" (or "Show _in_ folder" / "Show folder content", both not preferred) would be accurate.

Comment 13

4 years ago
Any opinions? New bug required?
(Reporter)

Comment 14

4 years ago
Ton, I don't have an opinion, but I do recommend filing a new bug. ("Clone" is the fastest way.)

Updated

2 years ago
Blocks: 1300562
You need to log in before you can comment on or make changes to this bug.