1300562 - On about:support, "Show Folder" (Windows) is misleading

Status: VERIFIED FIXED

(Toolkit :: General, defect, P5)

Description

[Ton [:Tonnes]]

+++ This bug was initially created as a clone of Bug #559500 +++

In bug 559500, the wording for opening the profile folder on Windows seems to have been erroneously changed to "Show Folder" even though there was consensus about "Open Folder" (see bug 559500 comment 4 and 5), possibly due to the Mac wording using "Show".

That bug changed "Open Containing Folder" to
Linux: Open Directory
Mac: Show in Finder
Win: Show Folder

Windows should probably need "Open Folder" rather than "Show Folder", since the folder _content_ is displayed and hence the folder itself is opened, like in Linux. Using "Show Folder", a user would expect to see e.g. C:\Users\<username>\AppData\Roaming\Mozilla\Firefox\Profiles\ i.e. the profile’s parent folder containing one or more profiles. I was told that’s what happens on Mac, but this is clearly not true on Windows.

Please change "Show Folder to "Open Folder" for Windows.

Comment 1

[Ton [:Tonnes]]

Attachment: bug 1300562_mc.patch

This should do it.

Comment 2

[Ton [:Tonnes]]

Attachment: bug 1300562_cc.patch

… and for TB.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8788957 [details] [diff] [review]
bug 1300562_mc.patch

You probably need a toolkit peer here.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8788958 [details] [diff] [review]
bug 1300562_cc.patch

I'm not active on Thunderbird any more, but I believe aceman can review this.

Comment 5

[:aceman]

Comment on attachment 8788958 [details] [diff] [review]
bug 1300562_cc.patch

Review of attachment 8788958 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18d6932a3c5b
Change "Show Folder" to "Open Folder" in Windows. r=Mossop

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/18d6932a3c5b

Comment 8

[:aceman]

Landed on comm-central too:
https://hg.mozilla.org/comm-central/rev/a2836536b7e00825a6e108ecd749460d54498cd3

Comment 10

[Aminul Islam Alvi]

I have reproduced this bug with Firefox 50.0b9(build ID:20161020152750)on 
windows 7(64 bit)

I have verified this bug as fixed with Firefox beta 51.0b12(build ID:20170105155013)
User Agent:Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

[testday-20170106]

Comment 11

[Bogdan Maris, Desktop Test Engineering]

(In reply to Aminul Islam Alvi from comment #10)
> I have reproduced this bug with Firefox 50.0b9(build ID:20161020152750)on 
> windows 7(64 bit)
> 
> I have verified this bug as fixed with Firefox beta 51.0b12(build
> ID:20170105155013)
> User Agent:Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101
> Firefox/51.0
> 
> [testday-20170106]

Thanks for verifying this bug!