On about:support, "Show Folder" (Windows) is misleading

VERIFIED FIXED in Firefox 51

Status

()

Toolkit
General
P5
normal
VERIFIED FIXED
8 months ago
4 months ago

People

(Reporter: Ton, Assigned: Ton)

Tracking

(Blocks: 1 bug, {polish})

Trunk
mozilla51
x86
Windows
polish
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 verified)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 months ago
+++ This bug was initially created as a clone of Bug #559500 +++

In bug 559500, the wording for opening the profile folder on Windows seems to have been erroneously changed to "Show Folder" even though there was consensus about "Open Folder" (see bug 559500 comment 4 and 5), possibly due to the Mac wording using "Show".

That bug changed "Open Containing Folder" to
Linux: Open Directory
Mac: Show in Finder
Win: Show Folder

Windows should probably need "Open Folder" rather than "Show Folder", since the folder _content_ is displayed and hence the folder itself is opened, like in Linux. Using "Show Folder", a user would expect to see e.g. C:\Users\<username>\AppData\Roaming\Mozilla\Firefox\Profiles\ i.e. the profile’s parent folder containing one or more profiles. I was told that’s what happens on Mac, but this is clearly not true on Windows.

Please change "Show Folder to "Open Folder" for Windows.
Priority: -- → P5
(Assignee)

Comment 1

8 months ago
Created attachment 8788957 [details] [diff] [review]
bug 1300562_mc.patch

This should do it.
Attachment #8788957 - Flags: review?(acelists)
(Assignee)

Comment 2

8 months ago
Created attachment 8788958 [details] [diff] [review]
bug 1300562_cc.patch

… and for TB.
Attachment #8788958 - Flags: review?(standard8)
Comment on attachment 8788957 [details] [diff] [review]
bug 1300562_mc.patch

You probably need a toolkit peer here.
Attachment #8788957 - Flags: review?(acelists) → review?(dtownsend)
Comment on attachment 8788958 [details] [diff] [review]
bug 1300562_cc.patch

I'm not active on Thunderbird any more, but I believe aceman can review this.
Attachment #8788958 - Flags: review?(standard8) → review?(acelists)

Updated

8 months ago
Attachment #8788957 - Flags: review?(dtownsend) → review+

Comment 5

8 months ago
Comment on attachment 8788958 [details] [diff] [review]
bug 1300562_cc.patch

Review of attachment 8788958 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8788958 - Flags: review?(acelists) → review+

Updated

7 months ago
Assignee: nobody → tonnes.mb
Status: NEW → ASSIGNED
Keywords: uiwanted → checkin-needed

Comment 6

7 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18d6932a3c5b
Change "Show Folder" to "Open Folder" in Windows. r=Mossop
Keywords: checkin-needed

Comment 7

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/18d6932a3c5b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Comment 8

7 months ago
Landed on comm-central too:
https://hg.mozilla.org/comm-central/rev/a2836536b7e00825a6e108ecd749460d54498cd3
Status: RESOLVED → VERIFIED

Updated

7 months ago
Duplicate of this bug: 1303741
QA Whiteboard: [good first verify]

Comment 10

4 months ago
I have reproduced this bug with Firefox 50.0b9(build ID:20161020152750)on 
windows 7(64 bit)

I have verified this bug as fixed with Firefox beta 51.0b12(build ID:20170105155013)
User Agent:Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

[testday-20170106]
(Assignee)

Updated

4 months ago
See Also: → bug 1309297
(In reply to Aminul Islam Alvi from comment #10)
> I have reproduced this bug with Firefox 50.0b9(build ID:20161020152750)on 
> windows 7(64 bit)
> 
> I have verified this bug as fixed with Firefox beta 51.0b12(build
> ID:20170105155013)
> User Agent:Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101
> Firefox/51.0
> 
> [testday-20170106]

Thanks for verifying this bug!
status-firefox51: fixed → verified
You need to log in before you can comment on or make changes to this bug.