Closed Bug 559609 Opened 12 years ago Closed 12 years ago

Remove non-toolkit dependency from aboutRights-unbranded.xhtml

Categories

(Toolkit Graveyard :: XULRunner, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
aboutRights-unbranded.xhtml depends on chrome://browser/locale/preferences/security.dtd which breaks it for non-FF apps.

This is already covered by bug 514817, but it doesn't need to be, as the reference in the unbranded file is actually redundant. Only aboutRights.xhtml still needs it for Firefox.

Therefore I'm proposing we just remove this dependency - in doing so, Thunderbird can at least pick up the unbranded version and we can think about the branded version later. Attaching patch to do just that.
Attachment #439275 - Flags: review?(gavin.sharp)
Blocks: 513025
Attachment #439275 - Flags: review?(gavin.sharp) → review+
Checked in: http://hg.mozilla.org/mozilla-central/rev/fc3befa99ab7
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Blocks: 559816
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.