Note: There are a few cases of duplicates in user autocompletion which are being worked on.

a11y mochitest for <input type="search">

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: surkov, Assigned: capella)

Tracking

(Depends on: 1 bug, Blocks: 1 bug, {access})

unspecified
mozilla15
access
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=js], URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
It's going to be autocomplete text field, we should expose it with COMBOBOX_ROLE.
(Reporter)

Comment 1

7 years ago
Autocomplete stuffs should be covered by bug 559766
Depends on: 559766
(Reporter)

Comment 2

6 years ago
It should be exposed as text entry with autocomplete state now. So all we should do is to add mochitest (add to states/test_inputs at autocomplete testing part and to tree/test_txtctrl.html).
(Reporter)

Updated

6 years ago
Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=js]
(Assignee)

Updated

5 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Created attachment 618404 [details] [diff] [review]
Patch (v1)

This patch looks like the one we just did for Bug 559759 ... let me know if there's something more to it that I'm missing and I'll address it ...
Attachment #618404 - Flags: feedback?(surkov.alexander)
(Reporter)

Comment 4

5 years ago
Comment on attachment 618404 [details] [diff] [review]
Patch (v1)

Review of attachment 618404 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/states/test_inputs.html
@@ +164,5 @@
> +  <a target="_blank"
> +     href="https://bugzilla.mozilla.org/show_bug.cgi?id=559747"
> +     title="Add a11y mochitests for input type=search">
> +    Mozilla Bug 559747
> +  </a>

in general you don't need a bug reference when the bug is about adding a mochitest
Attachment #618404 - Flags: review?(marco.zehe)
Attachment #618404 - Flags: feedback?(surkov.alexander)
Attachment #618404 - Flags: feedback+

Comment 5

5 years ago
Comment on attachment 618404 [details] [diff] [review]
Patch (v1)

r=me, thanks!

Note that in the long term, I'd like to see us use a new internal role for search inputs. Both mobile operating systems and Mac OS X know about this special input, and we should expose it correctly. But that should be done in a separate bug, since what we have now works on a basic level, and covering it with these tests here is perfect. Thanks for the patch!
Attachment #618404 - Flags: review?(marco.zehe) → review+
(Reporter)

Comment 6

5 years ago
Marco, please file a bug on it. You can make it a good first bug.
(Reporter)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/543a22b27d8e
Target Milestone: --- → mozilla15

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/543a22b27d8e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
Summary: make <input type="search"> accessible → a11y mochitest for <input type="search">
You need to log in before you can comment on or make changes to this bug.