560702 - [k] /en-US/search/ returns a 500 Internal Server Error

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://support-stage-new.mozilla.com/k/en-US/search/ yields a 500 Internal Server

https://support-stage-new.mozilla.com/k/en-US/search (without the trailing slash) works

Comment 1

[James Socol [:jsocol, :james]]

We're actually going to fix this in .htaccess, not Django, so 2.0 => 1.5.4.

Comment 2

[James Socol [:jsocol, :james]]

Attachment: tweak htaccess

Cleans up the .htaccess file (I'd accidentally left some extraneous $1s and $2s in there) and adds /? to the end of the Kitsune URLs. They still map to no-trailing-slash internally, and /k/en-US/search/ will still fail, but bug 561537 will make those redirect back to no trailing slash.

Comment 3

[Paul Craciunoiu [:paulc]]

Comment on attachment 441515 [details] [diff] [review]
tweak htaccess

One comment, hitting:
/search/
Doesn't work. It takes me to:
http://www.en-us.com/search
The rest looks good.

Comment 4

[James Socol [:jsocol, :james]]

The actual redirection here takes place in Kitsune, not in .htaccess. I'm working on nailing down why this particular issue happens.

Comment 5

[James Socol [:jsocol, :james]]

Attachment: htaccess patch

I should warn you: I have no idea _why_ this solves the problem. But it does.

Comment 6

[Paul Craciunoiu [:paulc]]

Comment on attachment 441902 [details] [diff] [review]
htaccess patch

>Index: webroot/htaccess.dist
>===================================================================
>--- webroot/htaccess.dist	(revision 66511)
>+++ webroot/htaccess.dist	(working copy)
>+RewriteRule ^search(.)$ /k/search$1 [L,QSA]
So I think just doing (/)? is enough. I couldn't figure out why /? doesn't work in this case. Seems like an escaping issue but wtf? So:
RewriteRule ^search(/)?$ /k/search$1 [L,QSA]
... worked for me.

Comment 7

[James Socol [:jsocol, :james]]

Attachment: another htaccess patch

Changed per your comment.

Comment 8

[Paul Craciunoiu [:paulc]]

Comment on attachment 441920 [details] [diff] [review]
another htaccess patch

WFM

Comment 9

[James Socol [:jsocol, :james]]

r66519 on trunk.

Comment 10

[James Socol [:jsocol, :james]]

I should point out: we did not fix this for URLs with /k in them. Those are still 404 errors in Django. However, no one should be going to URLs with /k in them.

See bug 561537 for handling this sort of thing in Django itself.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://support-stage-new.mozilla.com/en-US/search