56167 - Cursor does not change to a hand over link in a web page

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Marc Attinasi]

Hover over a link in a web page with a recent build and the cursor flickers
between a hand and an arrow, but ends up as an arror. Seen on Trunk and Branch
(even in commercial build 2000101108, from where I am writing this up).

Comment 1

[Marc Attinasi]

Recent regression. I'm looking over recent changes for likely suspects now.
Maybe nsEventStateManager 1.216? I'll try bakcing that out...

Comment 2

[Marc Attinasi]

Note that the cursor changes to a hand just fine in the personal toolbar and the
sidebar, just not in the content area.

Comment 3

[Marc Attinasi]

I backed out Hyatt's change to nsEventStateManager (1.216) and this is fixed.
Assigning to him to fix.

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

*** Bug 56094 has been marked as a duplicate of this bug. ***

Comment 5

[David Hyatt]

Darnit!  Ok, I guess I'm about ready to give up on this and punt it all back to 
joki now that he's back from vacation.  I can back out my fix, but then basic 
:hover will be broken again.

Comment 6

[David Hyatt]

Attachment: Patch that truly reverts us back to the way things were in PR2.

Comment 7

[David Hyatt]

Oops.  I screwed up the first patch.  Only look at the second patch.

Comment 8

[David Hyatt]

Attachment: Real patch.

Comment 9

[Chris Waterson]

a=waterson

Comment 10

[joki (gone)]

r: joki

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Can we at least get this checked in on the trunk?  The branch would sure be nice
too -- it's a basic UI feature in web browsers since at least NCSA Mosaic,
probably well earlier...

Comment 12

[Peter Trudelle]

Yikes!  rtm+  This is the fundamental affordance cue for the primary usage case
in a web browser. Many people only click on stuff that shows the hand, so this
could affect web app usability, and therefore click-through for netscape.com.  I
think this is 'pull-it-off-the-wire' territory.

Comment 13

[WD]

*** Bug 56252 has been marked as a duplicate of this bug. ***

Comment 14

[Jim Roskind]

Please land this on the trunk asap first.
Please update with status of build (re: regressions?) and renominated for branch
landing.
Marking need-info

Comment 15

[Ron Gavlin]

What's the holdup? Why hasn't this been landed on the trunk?

Comment 16

[sean echevarria]

Does the patch address the multiple mouseover events for text links issue or is 
that unrelated?

Comment 17

[Asa Dotzler [:asa]]

*** Bug 56470 has been marked as a duplicate of this bug. ***

Comment 18

[Doron Rosenberg (IBM)]

*** Bug 56566 has been marked as a duplicate of this bug. ***

Comment 19

[sean echevarria]

*** Bug 56658 has been marked as a duplicate of this bug. ***

Comment 20

[David Hyatt]

Please approve for branch checkin.

Comment 21

[Peter Trudelle]

PDT says rtm++, please land on branch ASAP

Comment 22

[David Hyatt]

Fixed on branch now too.

Comment 23

[Loco]

VERIFIED on Mac 10-18-08, NT 10-18-08, Linux 10-18-09 branch builds.  Adding 
vtrunk KW.

Comment 24

[Asa Dotzler [:asa]]

Verified Fixed on trunk builds
linux 101808 RedHat 6.2
win32 101804 NT 4
mac 101804 Mac OS9
Setting bug to Verified and removing vtrunk keyword

Comment 25

[Jerry Baker]

Mass removing self from CC list.

Comment 26

[Jerry Baker]

Now I feel sumb because I have to add back. Sorry for the spam.