561925 - Unable to register for any new account, as User already exists

Status: RESOLVED FIXED

(support.mozillamessaging.com Graveyard :: General, defect)

Description

[Masahiko Imanaka [:marsf]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:1.9.1.9) Gecko/20100315 Firefox/3.5.9
Build Identifier: 

When try to register a new account, "User already exists" error occured.
I've tried to any random username like "marsf2"or "marsf3", but they were not accepted.
The username and password are used alphabet only (with valid email).

A Japanese new contributor Torukb reported this, and I confirmed this, too.

Reproducible: Always

Steps to Reproduce:
1. Fill the register form and 5 digits number.
2. Click register button.
Actual Results:  
The page shows "User already exists" error.

Expected Results:  
If all random usernames hasn't been registerd on SuMoMo, it should be accept for new username.

Comment 1

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

confirmed

Comment 2

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

this will be fixed in SUMO 1.5.5 which is scheduled tentatively for next week i.e.
May 25, 2010
see:
1. https://wiki.mozilla.org/Support/SUMOdev_Meeting_Notepad
2. https://bugzilla.mozilla.org/buglist.cgi?quicksearch=OPEN+product%3Asupport+milestone%3A1.5.5

In the meantime:
:marsf please email Torukb's email address (and any other folks who want to register) and I'll create userids for them on SuMoMo manually

Comment 3

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

added :gozer (and :sancus  because it looks like we will have to update trunk to SUMO 1.5.5 at the end of may as well

Comment 4

[Masahiko Imanaka [:marsf]]

(In reply to comment #2)
> In the meantime:
> :marsf please email Torukb's email address (and any other folks who want to
> register) and I'll create userids for them on SuMoMo manually

Torukb is going to wait for SUMO 1.5.5.
Thank you.

Comment 5

[James Socol [:jsocol, :james]]

The problem is missing settings for the openfire database connection.

If you comment out lines 183-220 (the try-catch blocks there), does it fix the problem?

Comment 6

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

:jsocol, which file are you referring to? is it tiki-register.php?

Comment 7

[James Socol [:jsocol, :james]]

Oh man I completely forgot to mention the name of the file. Fail.

Yes, it's tiki-register.php.

Comment 8

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

Attachment: tiki register modified to remove call to openfire live chat database

:jsocol, your suggested modification (which is attached) from comment 5 didn't work, anything further to check or is there a log file to check?

Roland-Tanglaos-MacBook-Pro-2:webroot rolandtanglao$ svn commit -m "comment out openfire livechat database call when a new user registers as per comment 5 bug 561925" tiki-register.php 
Sending        tiki-register.php
Transmitting file data .
Committed revision 67694.

Comment 9

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

:sancus and :gozer, let's take 30 minutes next week and fix this problem for SuMoMo and then when SuMo has an official fix we'll look at it and (probably) use it!

Comment 10

[James Socol [:jsocol, :james]]

So the thing is: we added livechat_id to our users_users table and added a step to the registration that checks the Openfire database for uniqueness.

There is no "official fix" because there is no actual problem: we were just missing the configuration on one of our staging servers to talk to the Openfire database, and when it failed to connect to the database it was throwing an exception that got caught in the "user exists" try-catch block.

Lines 183-220 of tiki-register.php are where we do this check and where the connection to the Openfire database can fail, causing this behavior.

Comment 11

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

thanks james!

Well i applied that fix to trunk.support.mozillamessaging.com and it doesn't work so either i screwed up the fix (i am not a real developer! :-)) OR we have some other non SUMO related problem

I am now more confident than ever that :sancus, :gozer and i will get this working this week.

Comment 12

[Andrei Hajdukewycz [:sancus]]

This fix is correct, our trunk database was missing the livechat_id column however so that caused an error to still be displayed.

Comment 13

[Andrei Hajdukewycz [:sancus]]

This is working on production.

Comment 14

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

i just tried adding user flod, with email address [e-mail] and it failed with "User already exists" on live sumomo
but it worked when i logged in as roland (which has admin privileges) and then then added it from the tiki wiki back end

:sancus did the bug come back?

Comment 15

[Andrei Hajdukewycz [:sancus]]

refixed -- my rollback to fix the image stuff also broke this again; I had to merge the fix back in manually, even though when I rolled back I only specified the big merge in r68249.. not the commit in r68250. Oh well.