Add plugin check support via blocklist

VERIFIED FIXED in mozilla2.0b7

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: eviatarbach, Assigned: mossop)

Tracking

({APIchange})

Trunk
mozilla2.0b7
APIchange
Points:
---
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

(Whiteboard: [AddonsRewriteTestday][rewrite][strings], URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre

With the new in-tab add-on manager, there is no longer a link to http://www.mozilla.com/en-US/plugincheck/, as there was in the windowed one, which could be accessed by pressing "Find Updates" while on the Plug-Ins section. Doing this on the current one simply checks updates for the extensions.

As plug-in updates are essential for security, some sort of implementation should be built into the add-ons manager. I think the best way would be to include this: http://www.mozilla.com/en-US/plugincheck/, within the manager itself.

Reproducible: Always
Component: Menus → Add-ons Manager
Keywords: uiwanted
OS: Windows 7 → All
Product: Firefox → Toolkit
QA Contact: menus → add-ons.manager
Hardware: x86 → All
Whiteboard: [rewrite]
Version: unspecified → Trunk
Blocks: 550048
Severity: enhancement → normal
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [rewrite] → [AddonsRewriteTestday][rewrite]
While plugin check is extremely useful for add-on update checks, it is not being included in this iteration of the add-ons manager.  The reason is that add-ons are being updated by default in this design, so it would only be very temporarily that a user would see that an add-on is not up to date.  

Making add-on updates automatic is one of the main thrusts of the new design, but plug-in check is essentially a tool for manually keeping add-ons up to date.  So, by presenting it to user in this UI, we would both be alerting users that some add-ons need to be updated, but also burying the UI to manually update them (see bug 553502).  The users who would find plug-in check useful in the new UI are those who have decided to change their preferences in order to manually update add-ons, but these users are much more likely to be aware of add-on check in the first place.  I could see in a future iteration including something similar to add-on check for only the manual update case, but since we are focusing on the default case for now and plug-in check exists outside of the manager, it isn't necessary to include in this relese.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: uiwanted
Resolution: --- → WONTFIX
Reopening - Mossop says we can't do automatic updates for plug-ins currently, which means plug-in check is necessary.  I'll attach a mock.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
(Assignee)

Updated

7 years ago
blocking2.0: --- → final+
(In reply to comment #2)
> Reopening - Mossop says we can't do automatic updates for plug-ins currently,
> which means plug-in check is necessary.  I'll attach a mock.

Jennifer, I'm sure you wanted to attach the following mockup:
https://wiki.mozilla.org/images/thumb/9/9c/Plugin_manual_update_in_addonsmanager2342.png/800px-Plugin_manual_update_in_addonsmanager2342.png
Status: REOPENED → NEW
(Reporter)

Comment 4

7 years ago
Looks good! The buttons could do with some recolouring though. Maybe smaller too.
(Assignee)

Updated

7 years ago
Duplicate of this bug: 572583
(Assignee)

Updated

7 years ago
blocking2.0: final+ → beta2+
(Assignee)

Updated

7 years ago
Whiteboard: [AddonsRewriteTestday][rewrite] → [AddonsRewriteTestday][rewrite][apichange]
Keywords: APIchange
Whiteboard: [AddonsRewriteTestday][rewrite][apichange] → [AddonsRewriteTestday][rewrite]
Duplicate of this bug: 576858
(Assignee)

Updated

7 years ago
blocking2.0: beta2+ → final+
(Assignee)

Updated

7 years ago
blocking2.0: final+ → betaN+
(Assignee)

Updated

7 years ago
Assignee: nobody → dtownsend
(Assignee)

Comment 7

7 years ago
Needed by string freeze
blocking2.0: betaN+ → beta5+
(Assignee)

Comment 8

7 years ago
Created attachment 469191 [details] [diff] [review]
outdated warning patch rev 1

This simple patch adds warnings to known outdated plugins directing them to plugin-check. I'm not sure it completely fills this goal but I'm not sure exactly what else we can do easily for Firefox 4.

This is on top of the details view patch since it adds it to there too.
Attachment #469191 - Flags: review?(bmcbride)
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
Comment on attachment 469191 [details] [diff] [review]
outdated warning patch rev 1

Kinda feel like we should be doing more here, but I have no idea what. But this gets us the important bit in. Anything else can be followup fodder.
Attachment #469191 - Flags: review?(bmcbride) → review+
Ready for checkin?
(Assignee)

Comment 11

7 years ago
(In reply to comment #10)
> Ready for checkin?

No, this patch depends on others that look like they may slip past b5
(Assignee)

Updated

7 years ago
blocking2.0: beta5+ → beta6+
(Assignee)

Updated

7 years ago
Whiteboard: [AddonsRewriteTestday][rewrite] → [AddonsRewriteTestday][rewrite][strings]
(Assignee)

Comment 12

7 years ago
Landed: http://hg.mozilla.org/mozilla-central/rev/7739cff04a0b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago7 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
Depends on: 592947
No longer depends on: 592947
So what's the expected behavior for current builds? I have installed an old version of the Flash plugin but I don't get notified about an update.
(Assignee)

Comment 14

7 years ago
(In reply to comment #13)
> So what's the expected behavior for current builds? I have installed an old
> version of the Flash plugin but I don't get notified about an update.

See https://bugzilla.mozilla.org/show_bug.cgi?id=597124#c6 and below, however we have never added information about outdated plugins to the blocklist so you would have to create a custom blocklist to see it.

Comment 15

7 years ago
Build : Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20101005 Firefox/4.0b7pre
I don't have anything in AOM that look like the mockup, especially the AOM pane, even if "Update Add-ons automatically" is ticked.
For instance:
* with an up-to-date plugin, I don't have this "up to date" display.
* when I had Flash 10.1.82.76 installed, plugin check said it was vulnerable, but I didn't have the "Update now" button in the AOM pane.

Is there something wrong with plugin management on 64-bit Windows ?
I think so, see bug 600796 for Flash plugin and bug 584012 for QuickTime on 64-bit Windows.

Updated

7 years ago
Depends on: 602795

Updated

7 years ago
No longer depends on: 602795
(In reply to comment #14)
> See https://bugzilla.mozilla.org/show_bug.cgi?id=597124#c6 and below, however
> we have never added information about outdated plugins to the blocklist so you
> would have to create a custom blocklist to see it.

Which options I would have to add to such a blocklist entry? I can't find any information on the Wiki and MDN, to mark a plug-in as outdated.
(Assignee)

Comment 17

6 years ago
The docs here https://wiki.mozilla.org/Extension_Blocklisting:Code_Design, you can mark a plugin as outdated with severity=0 for plugins.
Tested with the following entry in the blocklist.xml file:

<pluginItem>
  <match name="name" exp="Shockwave Flash"/>
  <versionRange severity="0">
    <targetApplication id="{ec8030f7-c20a-464f-9b0e-13a3a9e97384}">
      <versionRange minVersion="3.5.*" maxVersion="4.0.*"/>
    </targetApplication>
  </versionRange>
</pluginItem>

Marking as verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110209 Firefox/4.0b12pre ID:20110209030359

Dave or Justin, can you remember if there was ever a discussion about adding outdated plugins to the blocklist? Probably sounds like a good idea as long as we do not have built-in support (bug 613305) for plugin-check in Firefox 4.0.
Status: RESOLVED → VERIFIED
Summary: New add-ons manager has no inclusion of plugin check → Add plugin check support via blocklist
You need to log in before you can comment on or make changes to this bug.