564870 - [ACR Extension] Update Compatibility Reporter for new Add-ons Manager

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P1)

Description

[Brian King [:kinger]]

A compatibility layer will *not* be built for add-ons to transition to the new EM API (bug 563412). This covers one type of add-on that will break in the new add-ons Manager. A lot of others will break for other reasons (see bug 562808).

Conclusion: Make the Compatibility Reporter work with the new add-ons manager quickly!

Comment 1

[Brian King [:kinger]]

The goal should be to keep a single XPI that is still compatible with builds before 3.7a5pre or whatever the Firefox version will be when it lands. This should be possible via separate overlays loaded via chrome.manifest flags.

Comment 2

[Brian King [:kinger]]

Dave, for now you can bypass bug 565610 by loading add-ons as chrome://mozapps/content/extensions/extensions.xul

Comment 3

[David McNamara [:mackers]]

The compatibility reported should now be working with the new Add-ons Manager (but maintains compatibility with the legacy EM):

- compatibility button showing on 3.7 in list view and detail view
(themes and extensions).
- submit dialog now using new AddonManager API in 3.7.
- uninstall listener now using new AddonManager API in 3.7.
- remains compatible with legacy Extension Manager stuff (< 3.7).

Snags:

- Only works in 3.7 when extensions manager loading like
"chrome://mozapps/content/extensions/extensions.xul" (see
https://bugzilla.mozilla.org/show_bug.cgi?id=565610)


r67270.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

David, do we have a dev XPI somewhere we can use for testing?

Comment 5

[Brian King [:kinger]]

(In reply to comment #4)
> David, do we have a dev XPI somewhere we can use for testing?

Yes, see:
https://bugzilla.mozilla.org/attachment.cgi?id=448362
(attachment to bug 565610)

Comment 7

[Brian King [:kinger]]

Attachment: ACR compatible with 3.7a6pre

New ACR XPI compatible with 3.7a6pre
Reminder: only works correct when add-ons manager is loaded via this chrome url:
chrome://mozapps/content/extensions/extensions.xul

Comment 8

[Jan Bauer]

The ACR makes other "incompatible" addons still working, but compatibility reporting does not work anymore.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Jan, please read the former comments. Everything points to bug 565610 which has to be fixed first. Meanwhile use the chrome url.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Tested with latest ACR development build and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a6pre) Gecko/20100623 Minefield/3.7a6pre

Now with bug 565610 fixed it looks good. The Compatibility button is visible and sending reports work. Marking as verified fixed.

Comment 12

[Jan Bauer]

Also working on Win x64, tested with Mozilla/5.0 (Windows; U; Windows NT 6.0; Win64; x64; en-US; rv:2.0b2pre) Gecko/20100701 Minefield/4.0b2pre. Looks good :)