565600 - Buttons should link directly to files for experimental add-ons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[debueb]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3

I am the dev of the addon AutoLogin
https://addons.mozilla.org/en-US/firefox/addon/119049/
It cannot be installed any longer, giving a incorrect file hash (Error -261). If I try to install it manually (drag n' drop), I get "not a valid install package (-207)". This version has previously worked. Also, I would upload a "new" version via AMO, but I cannot login any more, although password is reset (and seems to be ok b/c no error message is shown, but I do not see "my account", instead it gives me the login screen over and over again). Any help would be appreciated.

Reproducible: Always

Steps to Reproduce:
1. Install https://addons.mozilla.org/en-US/firefox/addon/119049/
2. Login to https://addons.mozilla.org/en-US/firefox/users/login?to=%2Fen-US%2Ffirefox%2Faddon%2F119049%2F

Comment 1

[Tim (fmdeveloper)]

The login issue sounds the same as Bug 566111

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Moving to AMO component.

Comment 4

[Wil Clouser [:clouserw]]

I think the login issue is fixed with bug 566377 so let's skip that discussion in this bug.

Regarding the download issue, the file exists on our servers.  The download is failing because getLatestFileByAddonId() is looking only for public files, and, finding none, returns 0.

That function hasn't changed since last year, so, I've got to ask - how was this working before?  Is this a download button thing going to a new URL?

Comment 5

[Jeff Balogh (:jbalogh)]

According to http://jbalogh.khan.mozilla.org/amo/site/en-US/firefox/addon/161742, we were serving experimental add-ons with a link like "/amo/site/en-US/firefox/downloads/file/89024/forum_preview-0.005-fx.xpi?src=addondetail".

Comment 6

[debueb]

Alright, tried to login today and it works again. Issue https://bugzilla.mozilla.org/show_bug.cgi?id=566377 seems to have resolved my problem. Also, the download of my addon doesn't give an error no more. Thanks for your support :)

Comment 7

[Fred Wenzel [:wenzel]]

(In reply to comment #5)
> According to
> http://jbalogh.khan.mozilla.org/amo/site/en-US/firefox/addon/161742, we were
> serving experimental add-ons with a link like
> "/amo/site/en-US/firefox/downloads/file/89024/forum_preview-0.005-fx.xpi?src=addondetail".

Yes, that's correct. The addon-1234-latest shortcut only exists for public add-ons, pointing to the last public version. 

Does "we were" imply that that has changed in Zamboni? If so, we need to reopen this bug and fix it -- either by making the link work with any add-on, or by not using -latest with experimental add-ons. (I prefer the latter, because the semantics of the former would be fuzzy).

I'll reopen this for now, and if Jeff thinks this is fixed already, he can close it again. Thanks!

Comment 8

[Justin Scott [:fligtar]]

Fred's right; we explicitly did not allow unreviewed add-ons to be permalinked because we want users to come to the site and see the warnings. This should remain true for as long as the current sandbox system is in place.

Comment 9

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commits/e03bff6a6

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

I now get:

"The download of https://preview.addons.mozilla.org/downloads/file/87737/autologin-1.2.4-fx.xpi?src=addondetail failed: -2", instead of:

"The download of https://addons.mozilla.org/en-US/firefox/downloads/latest/119049/addon-119049-latest.xpi?src=addondetail failed: -2"

Progress!  (Something about the files not being updated?  Oh, and what's the -2 error; that's new to me).

Srsly, does anybody know what -2 is?  Since that error is both in prod and preview, unsure if that's a file-doesn't-exist problem or what.

Comment 12

[Jeff Balogh (:jbalogh)]

Forcing ?confirmed=1 in http://github.com/jbalogh/zamboni/commits/b2c903d4f to get around the login requirement.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

https://preview.addons.mozilla.org/downloads/file/87737/autologin-1.2.4-fx.xpi?src=addondetail&confirmed=1

GET /downloads/file/87737/autologin-1.2.4-fx.xpi?src=addondetail&confirmed=1 HTTP/1.1
Host: preview.addons.mozilla.org
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
<snip>

HTTP/1.1 302 Found
Server: Apache
X-Backend-Server: pm-app-amo24
Cache-Control: no-cache
Content-Type: text/html; charset=UTF-8
Date: Tue, 18 May 2010 20:06:27 GMT
Location: https://preview.addons.mozilla.org/en-US/downloads/file/87737/autologin-1.2.4-fx.xpi?src=addondetail&confirmed=1
Keep-Alive: timeout=5, max=1000
X-AMO-ServedBy: pm-app-amo24.mozilla.org
Pragma: no-cache
Via: Moz-Cache-zlb05
Connection: Keep-Alive
X-Powered-By: PHP/5.2.9
Content-Length: 0
----------------------------------------------------------
https://preview.addons.mozilla.org/en-US/downloads/file/87737/autologin-1.2.4-fx.xpi?src=addondetail&confirmed=1

GET /en-US/downloads/file/87737/autologin-1.2.4-fx.xpi?src=addondetail&confirmed=1 HTTP/1.1
Host: preview.addons.mozilla.org
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
<snip>

HTTP/1.1 302 Found
Server: Apache
X-Backend-Server: pm-app-amo24
Cache-Control: no-cache
Content-Type: text/html; charset=UTF-8
Date: Tue, 18 May 2010 20:06:27 GMT
Location: https://preview.addons.mozilla.org/en-US/firefox/downloads/file/87737/autologin-1.2.4-fx.xpi?src=addondetail&confirmed=1
Keep-Alive: timeout=5, max=999
X-AMO-ServedBy: pm-app-amo24.mozilla.org
Pragma: no-cache
Via: Moz-Cache-zlb05
Connection: Keep-Alive
X-Powered-By: PHP/5.2.9
Content-Length: 0
----------------------------------------------------------
https://preview.addons.mozilla.org/en-US/firefox/downloads/file/87737/autologin-1.2.4-fx.xpi?src=addondetail&confirmed=1

GET /en-US/firefox/downloads/file/87737/autologin-1.2.4-fx.xpi?src=addondetail&confirmed=1 HTTP/1.1

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

This works in prod now: https://addons.mozilla.org/en-US/firefox/addon/119049/