566282 - Error message: this._updateVisibleText is not a function

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Ginn Chen]

Startup thunderbird, get this error message in terminal:

       -- Exception object --
       + message (string) 'this._updateVisibleText is not a function'
       + fileName (string) 'chrome://messenger/content/search.xml'
       + lineNumber (number) 140
       + stack (string) '()@chrome://messenger/content/search.xml:140
       '
       + name (string) 'TypeError'
       *
       -- Stack Trace --
       ()@chrome://messenger/content/search.xml:140

See Bug 561054 comment #11 #12.

comm-central only, comm-1.9.2 is fine.

Comment 2

[Nomis101]

I can confirm this. You also see this constantly in the error console.

Error: this._updateVisibleText is not a function
Source File: chrome://messenger/content/search.xml
Line: 140

I recognize this now since a few month, so have no idea when it begins. But couldn't find any obvious  broken thing because of this. 

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b4pre) Gecko/20100805 Thunderbird/3.2a1pre

Comment 3

[Nomis101]

This has to do with Bug 547224, so you can use this patch as a direction to fix this issue in search.xml.
Today I've made a patch that works for me, it fixes the error and preserves the placeholder text. But I need to test this first with clean trunk code and than I'll uploade it.
This is related to Bug 551747, fixing Bug 551747 will likely also fix this bug.

Comment 4

[Nomis101]

Attachment: fix (?)

This fixed it for me. I don't have the error anymore in the console, but I still have the placeholder text.
Is this fix OK like this?

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

It looks like we shouldn't be using emptytext anymore and instead should be using placeholder.

https://developer.mozilla.org/en/XUL/Attribute/emptytext

It's not immediately obvious if such a change would reduce the need to poke things...

In any event, thank you very much for the patch.  I've pushed it to the try server to see how the mozmill tests like it, but it looks pretty safe.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 467506 [details] [diff] [review]
fix (?)

The patch passed the mozmill runs.

Thanks again for the patch!

Comment 7

[Nomis101]

(In reply to comment #5)
> It looks like we shouldn't be using emptytext anymore and instead should be
> using placeholder.
> 
> https://developer.mozilla.org/en/XUL/Attribute/emptytext

So it is, after this patch has landed, I will change all emptytext to placeholder in Bug 551747. :-)


(In reply to comment #4)
> ... but I still have the placeholder text.
I must correct myselfe. This patch fixes the missing placeholder text in the global search. I have no text in current nightlys, but I have one with my patch.


(In reply to comment #6)
> Thanks again for the patch!
You're welcome! :-)

Comment 8

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/e1087b5157e2