567714 - Header should be as heigh as the blue "selected" background of a panelitem

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Michael Kohler [:mkohler]]

Attachment: Screenshot

When you click on "Get Add-ons", the blue border around that item is bigger than the header. It should be as high as the header. See the screenshot for more information.

Comment 1

[Michael Kohler [:mkohler]]

Attachment: Patch

Comment 2

[[not reading bugmail]]

bug 562949 could be marked as a dupe since you have patch here.

Comment 4

[[not reading bugmail]]

Attachment: latest trunk height diff

Micheal this is what I see as a height with latest trunk, I see it doesn't match your screenshot, mine show the opposite scenario.

Comment 5

[Alice0775 White]

This bug should examine after fixing of Bug 557916

Comment 6

[Michael Kohler [:mkohler]]

Oh, right.

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 447032 [details] [diff] [review]
Patch

You need to make sure the header and the category boxes are sized in the same way I think. Currently one is sized by px and the other by em. The latter is probably the correct choice but you may run into problems with the different font sizes.

Comment 8

[Tony Mechelynck [:tonymec]]

Isn't it a coincidence that the tabs of the addon-manager sidebar and the title of its main pane are approximately the same height? I could imagine one theme using small tabs (just high enough for the text using a font similar to that for the menus, more or less as in the browser sidebar) and another one expanding them vertically until those tabs taken together occupy the whole height available, while the main pane title would be "just a few percent higher" than a default <h1> in both cases.

Comment 9

[Dave Townsend [:mossop]]

It is a coincidence yes, however I tend to agree that it is fairly ugly looking to have them so close to being the same yet still different. So I think either we should make them the same or more obviously different. It isn't a terribly high priority to fix this though.

Comment 10

[Michael Kohler [:mkohler]]

(In reply to comment #9)
> It is a coincidence yes, however I tend to agree that it is fairly ugly looking
> to have them so close to being the same yet still different. So I think either
> we should make them the same or more obviously different. It isn't a terribly
> high priority to fix this though.

I will a take a look at this bug again once bug 557916 is fixed..

Comment 11

[Michael Kohler [:mkohler]]

Since there will be another css-redesign after the Summit, this bug will likely fix then, or will not even exist anymore.

https://wiki.mozilla.org/Firefox/Projects/Extension_Manager_Redesign/design#New_Theme_Wireframes

Comment 12

[Michael Kohler [:mkohler]]

This is not a problem anymore since the AddonsManager has been redesigned.