567956 - Sometimes inspector panels take up space in browser window as though they are a normal box

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Screenshot

Sometimes, the highlighter-pane and inspector-panel panels will take up space in the browser window. Their contents are not visible, but the panels take up space as though they're normal XUL boxes (rather than panels/popups). The mainPopupSet expands to make room for them, creating a large empty space above the Menu Bar (see attached screenshot). Adding a hidden="true" attribute to these panels will fix the described symptoms.

I haven't found a way to reliably reproduce this. It's happened a couple of times when I've switched back to a Firefox window or after I've been logged in via RDP, but that may be a coincidence.

Comment 1

[Philip Chee]

Known XUL bug. using hidden="true" is the current workaround used in other similar problems. But I thought Enn fixed this on trunk.

Comment 2

[Rob Campbell [:rc] (:robcee)]

yeah, that's an odd one. I've seen something similar when hitting the "capsule" button in an OS X titlebar. I'll try the mentioned workaround.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #1)
> Known XUL bug. using hidden="true" is the current workaround used in other
> similar problems. But I thought Enn fixed this on trunk.

Interestingly, doing this should also improve startup time, since the XBL bindings won't get attached until the popup is shown (we discovered this with Ubiquity - it also fixed a bunch of other weirdness). So it may be a good thing to do even if the underlying popup problem is fixed.

Comment 4

[Rob Campbell [:rc] (:robcee)]

I thought I was doing this and forgot that the style and dom panels haven't landed yet.

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#223

I'm already setting that attribute on both panels and setting the attribute to false on initialization:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/inspector.js#535

Any ideas?

Comment 5

[Philip Chee]

Nope, sorry. That's the way the other panels in browser.xul do it.

Comment 7

[Kevin Dangoor]

I think this bug is no longer relevant. Can we close it?

Comment 8

[Rob Campbell [:rc] (:robcee)]

We believe this is fixed. Reopen if necessary.