Closed Bug 569139 Opened 14 years ago Closed 14 years ago

Personas/Lightweight themes footer image not shown in Thunderbird 3.1 statusbar

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
trivial

Tracking

(thunderbird3.1 .1-fixed)

RESOLVED FIXED
Thunderbird 3.3a1
Tracking Status
thunderbird3.1 --- .1-fixed

People

(Reporter: gekacheka, Assigned: gekacheka)

References

Details

(Keywords: polish, regression)

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4) Gecko/20100526 Thunderbird/3.1

When a Persona / Lightweight-Theme is selected and has a footer image, Thunderbird 3.1 <= rc1 does not display the footer image in the status bar.  
It displays the background color, but not the image.

Thunderbird 3.0.x does display the footer image.

Reproducible: Always

Steps to Reproduce:
1. install personas add on (needed to load personas, but not needed for display)
   https://addons.mozilla.org/en-US/thunderbird/addon/10900/
2. select a persona with a footer image, such as Groovy Blue
   Tools / Personas / Most Popular / Groovy Blue

Actual Results:  
Statusbar shows different plain background color but does not show an image.

This is even more noticeable when the background color does not match the image, such as in the persona "Cherry Hotmail skin"

Expected Results:  
Status bar should show image similar to header image behind toolbars.

Difference from Firefox 3.6 is that thunderbird's window element has no lightweightthemesfooter attribute with the id of the footer element.

http://mxr.mozilla.org/mozilla-central/source/toolkit/content/LightweightThemeConsumer.jsm#41

To fix, add it to chrome/messenger.jar!/content/messenger/messenger.xul:

--- a/content/messenger/messenger.xul
+++ b/content/messenger/messenger.xul
@@ -38,7 +38,8 @@
         persist="width height screenX screenY sizemode"
         toggletoolbar="true"
         windowtype="mail:3pane"
-        lightweightthemes="true">
+        lightweightthemes="true"
+        lightweightthemesfooter="status-bar">
Keywords: polish, regression
cd mail/base/content/messenger.xul
patch -l -p 1 -i file.patch
Attachment #449522 - Flags: review?(philringnalda)
Assignee: nobody → gekacheka
Attachment #449522 - Flags: review?(philringnalda) → review+
Comment on attachment 449522 [details] [diff] [review]
v1 proposed patch to mail/base/content/messenger.xul

I've just noticed this patch and I like it. Hence stealing review and r=Standard8.

Thanks for fixing this.
Oh and normally we like our patches to be created from an hg diff (so that they can easily be imported), so here's the hg version of the patch.
Attachment #449522 - Attachment is obsolete: true
Attachment #451271 - Flags: review+
Checked into the trunk builds: http://hg.mozilla.org/comm-central/rev/8bc14185be99
Status: NEW → RESOLVED
Closed: 14 years ago
OS: Windows XP → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
Comment on attachment 451271 [details] [diff] [review]
proposed patch to mail/base/content/messenger.xul

We should take this on branch for 3.1.1 (too late for 3.1).
Attachment #451271 - Flags: approval-thunderbird3.1.1?
Attachment #451271 - Flags: approval-thunderbird3.1.1? → approval-thunderbird3.1.1+
Hello. I am running Thunderbird 3.1.1, Windows XP SP3. This problem still persists. I have tried a fresh reinstall, and a test profile with only the Personas 1.5.3 extension installed.

There is no footer graphic displayed, just the accent color.

It is possible to get the footer graphic to display by choosing "recently selected" or previewing the lightweight theme in the menu, but it only lasts for the session.

Downgrading to 3.0.6 with current profile data works as expected. This may need to be reopened.
(In reply to comment #8)
> Hello. I am running Thunderbird 3.1.1, Windows XP SP3. This problem still
> persists. I have tried a fresh reinstall, and a test profile with only the
> Personas 1.5.3 extension installed.

It works for me after I change the persona/lightweight-theme.  The lightweightthemesfooter attribute was missing before.  Therefore, the footer image was not installed before.  So simply upgrading Thunderbird does not install the footer image.  Switch personas/lightweight-theme, which will install the images.
(In reply to comment #8)
> Hello. I am running Thunderbird 3.1.1, Windows XP SP3. This problem still
> persists. I have tried a fresh reinstall, and a test profile with only the
> Personas 1.5.3 extension installed.
> 
> There is no footer graphic displayed, just the accent color.

You may also be seeing
Bug 579672 - Personas/Lightweight-theme footer not restored after restart (getElementById returns null, incomplete DOM?)

[After restart I see the background color but not the footer image.
Switching to another Persona/lightweight-theme installs the footer image.
Follow up at bug 579672.]
(In reply to comment #10)
> (In reply to comment #8)
> > Hello. I am running Thunderbird 3.1.1, Windows XP SP3. This problem still
> > persists. I have tried a fresh reinstall, and a test profile with only the
> > Personas 1.5.3 extension installed.
> > 
> > There is no footer graphic displayed, just the accent color.
> 
> You may also be seeing
> Bug 579672 - Personas/Lightweight-theme footer not restored after restart
> (getElementById returns null, incomplete DOM?)
> 
> [After restart I see the background color but not the footer image.
> Switching to another Persona/lightweight-theme installs the footer image.
> Follow up at bug 579672.]

Will do. That appears to fit the behavior.
You need to log in before you can comment on or make changes to this bug.