569376 - [firefoxcup] Add msgctxt to strings that appear both in messages and firefoxcup domains

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Staś Małolepszy :stas]

flod writes in bug 567534 comment 7:

"You added the missing strings, but "Get Personal" is still taken from somewhere
else (maybe from the main AMO's .po file?)

It still shows "Personalizzazione" instead of "Personalizza" on the stage site
(http://tinyurl.com/2uw2znd)"

This is because messages.po and z-firefoxcup.po are msgcat'ed together with --use-first, and for duplicate strings, the translation from messages.po is taken. A solution would be to add context to the string in firefoxcup domain.

Comment 1

[Francesco Lodolo [:flod]]

Side note: same problem with the "Support" link in the header.

Comment 2

[Staś Małolepszy :stas]

Hey Alex: do you think we could fix this today (morning PT)?

Comment 3

[Staś Małolepszy :stas]

Just noticed Alex wasn't CC'ed on this bug before. Alex, please see previous comments.

Comment 4

[Staś Małolepszy :stas]

Marking P2 for now. Flod was able to work around the problem (see bug 567543 comment 4).

We might still want to fix this for the next push though.

Comment 5

[Staś Małolepszy :stas]

Since the website is live, I think it's better to leave it as it is, just so that we don't break something :) Adding msgctxt in the code would require us to go in and edit all PO files and add it there too. That may be, as we've already seen for Italian, an error-prone process which I prefer to avoid.

Wontfixing.