571695 - android build broken on Mac OS X host

Status: RESOLVED DUPLICATE of bug 598261

(Firefox Build System :: General, defect)

Description

[Harry Li]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.4) Gecko/20100527 Firefox/3.6.4 GTB7.1
Build Identifier: 

There are two issues with js/src's autoconf script in m-c repo. patch is here. However the first fix to exclude objc lib is ugly and I'm not sure how to deal that better, currently.

Reproducible: Always

Comment 1

[Harry Li]

Attachment: patch

patch against m-c with http://hg.mozilla.org/users/mwu_mozilla.com/test-repo/ patches.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 450865 [details] [diff] [review]
patch

So, the right fix for the LDFLAGS issue is most likely to make a HOST_LDFLAGS so we can prevent host and target LDFLAGS from mixing and messing each other up. The top level configure.in file has it.. not sure why js/src/configure.in doesn't.

Adding RANLIB to the exports looks right.

Comment 3

[Harry Li]

Attachment: patch update

Updated. However not sure if this will break other platform.

Comment 4

[Michael Wu [:mwu]]

There's a number of other things that need to be updated to do HOST_LDFLAGS properly. I'll take a look at it. Removing dep on bug 552567 since this won't block our standard builds on Linux.

Comment 6

[Michael Wu [:mwu]]

Comment on attachment 450913 [details] [diff] [review]
patch update

Hm, on second thought this may be enough. Looks like it passes the tryserver.

Comment 7

[(not currently active) Ted Mielczarek]

Apparently fallout from bug 543081.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

is this ready land?

Comment 9

[Michael Wu [:mwu]]

If it still applies, yes.

Comment 10

[Dão Gottwald [:dao]]

Needs approval2.0.

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Does this really need explicit approval to land?  It is a bustage fix after all.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 450913 [details] [diff] [review]
patch update

Removing approval; this has languished so long that I'm no longer sure if this patch is needed or still applies. Renominate with risk v. reward if you'd like.

Comment 13

[Dave Townsend [:mossop]]

This ended up getting fixed in bug 598261