57189 - hitting reload after scrolling when quicktime movie is playing crashes browser

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[shrirang khanzode]

build: 20001018 mac branch
plugin:quiktime 4.1.1

This bug has spawned from bug 57186

Steps:
1 Go to the above url
2 When the movie plays, scroll using the horiz/vert scrollbars
3 You wil lsee garbage (bug 57186)
4 Now, click on RELOAD or BACK button of the browser
5 Observe that browser crashes

Stack trace from cyclone :


 Call Stack:    (Signature = QuickTime Web Helper + 0x8254 (0x16bcc404) 
7e48f405) 
     
   QuickTime Web Helper + 0x8254 (0x16bcc404) 
                                                  
     
   QuickTime Web Helper + 0xa84 (0x16bc4c34) 
                                                  
     
   ns4xPluginStreamListener::OnFileAvailable() 
                                                 [ns4xPluginInstance.cpp, line 
280]
     
   nsPluginStreamListenerPeer::OnFileAvailable() 
                                                 [nsPluginHostImpl.cpp, line 
1394]
     
   nsPluginStreamListenerPeer::OnStopRequest() 
                                                 [nsPluginHostImpl.cpp, line 
1275]
     
   nsHTTPFinalListener::OnStopRequest() 
                                                 [nsHTTPResponseListener.cpp, 
line 1157]
     
   nsHTTPFinalListener::OnDataAvailable() 
                                                 [nsHTTPResponseListener.cpp, 
line 1196]
     
   InterceptStreamListener::OnDataAvailable() 
                                                 [nsCachedNetData.cpp, line 
1213]
     
   nsHTTPServerListener::OnDataAvailable() 
                                                 [nsHTTPResponseListener.cpp, 
line 554]
     
   nsOnDataAvailableEvent::HandleEvent() 
                                                 [nsAsyncStreamListener.cpp, 
line 399]
     
   nsStreamListenerEvent::HandlePLEvent() 
                                                 [nsAsyncStreamListener.cpp, 
line 97]
     
   PL_HandleEvent() 
                                                 [plevent.c, line 580]
     
   PL_ProcessPendingEvents() 
                                                 [plevent.c, line 513]

Comment 1

[Peter Lubczynski]

accepting, adding crash keyword and nominating for rtm

Comment 2

[Peter Lubczynski]

I know this is a problem [as I've seen it before] but I just can't reproduce it. 
I'm using 10/18 and tried on both the trunk and branch. Perhaps it's gone away? 

Shrir, am I following your steps correctly? While the movie was downloading 
[green PREVIEW screen visible] I scrolled. I hit play [movie started playing] 
then I hit RELOAD and it reloaded fine. Repeated those steps with BACK. Same 
results. Tried all sorts of combinations and still no crash. Must I wait for the 
movie to finish downloading?

Adding Chris Petersen to cc:
Chris, haven't you seen this too?

Comment 3

[shrirang khanzode]

Peter, from what you say, I think you are doing it right. No, you do not have to 
wait for the movie to download fully or anything. I just scroll as soon as the 
green thing appears on the movie and just press RELOAD. Am using today's branch 
build on mac. This is consistently happening to me 100%

Comment 4

[Peter Lubczynski]

Shrir,

Since I can't get this to happen on the above URL, can you create a simplified 
testcase?

Thanks.

Comment 5

[shrirang khanzode]

Attaching a testcase. However, I am not very consistently crashing on it. I 
scrolled (blurred movie appeared and then hit RELOAD 4-5 times). On the url gvn 
above, I don't have to do it this many times. The stack trace is the same. 

http://cyclone/reports/incidenttemplate.CFM?reportID=124&style=0&tc=14&cp=1&ck1=
SUser+email+address&cd1=%25shrir%40netscape%2Ecom%25&co1=like&bbid=19468159

Comment 6

[shrirang khanzode]

Attachment: quicktime movie

Comment 7

[shrirang khanzode]

Oops..forgot to mention, keep the browser window small in size..so that..both 
scrollbars appear..and then try this.Thx.

Comment 8

[Frank Tang]

I can reproduce this with http://www.apple.com/trailers/wb/get_carter.html with 
my Mac 10/23 pull branch local build. but I cannot reproduce this with 
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=17651

Comment 9

[Frank Tang]

change platform to Macintosh from PC

Comment 10

[Frank Tang]

Here is the last Mozilal code


253 NS_IMETHODIMP
254 ns4xPluginStreamListener::OnFileAvailable(nsIPluginStreamInfo* pluginInfo, 
255                                           const char* fileName)
256 {
257     const NPPluginFuncs *callbacks;
258     NPP                 npp;
259 
260     pluginInfo->GetURL(&mNPStream.url);
261 
262     mInst->GetCallbacks(&callbacks);
263     mInst->GetNPP(&npp);
264 
265     if (callbacks->asfile == NULL)
266         return NS_OK;
267 
268 #if !TARGET_CARBON
269     // pinkerton
270     // relies on routine descriptors, not present in carbon. 
271     // We need to fix this.
272 
273     PRLibrary* lib = nsnull;
274     if(mInst)
275       lib = mInst->fLibrary;
276 
277     NS_TRY_SAFE_CALL_VOID(CallNPP_StreamAsFileProc(callbacks->asfile,
278                              npp,
279                              &mNPStream,
280                              fileName), lib);
281 #endif
282  
283     return NS_OK;
284 }

The crash happen INSIDE the plugin. I think this is very difficult to debug 
since we don't have the source code of this plugin. Anything could happen inside 
the plugin code.

Comment 11

[Frank Tang]

add av to the cc list since he is the last one who touch the last mozilla code 
ont the stack.

Comment 12

[av (gone)]

Right. And this was actually the reason I put try/catch wrapper around all the 
plugin calls. But only on Windows (bug 33105). If Mac has something similar 
for catching unhandled exceptions you can add the platform dependent part in 
nsPluginSafety.h then on the crash inside the plugin the warning message pops up 
without crashing Mozilla. 

Comment 13

[Peter Lubczynski]

The patch to bug 54186 may fix this. I can not reproduce this at all so perhaps 
someone else would like to try.

Comment 14

[Peter Lubczynski]

I checked the patch into the trunk on Friday. Works good for me, but I 
can't reproduce in the first place.

Can someone re-test with a nightly trunk and see if it still crashes. Thanks.

Comment 15

[shrirang khanzode]

I checked with a branch build on mac (2000-10-31-14-MN6) and this no longer 
seems to crash .Working fine. Will check on trunk.

Comment 16

[Peter Lubczynski]

Marking FIXED per last comments.

Comment 17

[shrirang khanzode]

works great on mac trunk build 1127. VERIFIED

Comment 18

[shrirang khanzode]

*** Bug 62685 has been marked as a duplicate of this bug. ***