573903 - Beta versions show on all versions page with normal buttons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Dave Garrett]

The all versions page is now showing beta versions in the list mixed in with the stable versions. Either:

a) If this is unintentional, they need to be hidden.
b) If this is intentional, they need beta-ish styling. (see also bug 565136)

I'd prefer (b) myself as these files do fall under the broad category of "all".

Comment 1

[Dave Garrett]

Here's an easy to see example. The "pre" versions are in the beta channel.

https://addons.mozilla.org/en-US/firefox/addon/5791/versions/
https://preview.addons.mozilla.org/en-US/firefox/addon/5791/versions/

The main addon details page doesn't seem to have any problems, even though the latest file, 4.0.7pre, is currently at the top of the all versions list.

Comment 2

[Jeff Balogh (:jbalogh)]

fligtar: we don't have special Beta styling.  Should we reuse unreviewed styles here?

Comment 3

[Justin Scott [:fligtar]]

(In reply to comment #2)
> fligtar: we don't have special Beta styling.  Should we reuse unreviewed styles
> here?

See bug 565136

Comment 4

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commits/01269f9

Comment 5

[Dave Garrett]

Verified FIXED on
https://preview.addons.mozilla.org/en-US/firefox/addon/5791/versions/

Button styling part is done but there's no warning popup.
Bug 574100 filed as a follow up for that.