574676 - Fix Page Info tab highlighting in Windows theme

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[Maniac Vlad Florin (:vladmaniac)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100625 Minefield/3.7a6pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100625 Minefield/3.7a6pre

Selected tab in "Page Info" Menu should change color (appear as highlighted on MouseOver() event). 

Reproducible: Always

Steps to Reproduce:
1. Open any web page in the URL bar. (e.g. www.yahoo.com)
2. Navigate Tools → Page Info





Actual Results:  
Menu Items are static for Page Info while active for other Menu's (e.g. Bookmark Manager). No feedback provided for performing button events. 

Expected Results:  
Inspect the Main Menu Icons. When performing button actions e.g. mouse click, mouse over, selection, etc. button should react with feedback (be highlighted)

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Screen shot of the lack of highlighting

As well as not showing a highlight colour when mousing over one of the icons, the currently selected one isn't highlighted either.  (In the screenshot, the selected icon is "Media", and my mouse pointer was over the "Permissions" icon.)

Comment 2

[Andrés Delfino]

This is a regression from Firefox 3.6.6.

Comment 3

[Andrés Delfino]

Could anyone please add "regression" (with no quotes) to keywords? Can't do that myself.

Comment 4

[Tanner M. Young [:tmyoung]]

I don't know how we broke it, but I will see if I can find out.

Comment 5

[Tanner M. Young [:tmyoung]]

We're missing "#viewGroup > radio[selected="true"]" in our css file, which extensions.css had, but it was removed by Bug 560602 in http://hg.mozilla.org/mozilla-central/rev/2dcd870f9e31.

I'll try to fix this as quickly as possible.

Comment 6

[Tanner M. Young [:tmyoung]]

Is this a problem on any other OS than windows?

Comment 7

[Tanner M. Young [:tmyoung]]

Attachment: Patch v. 1.0

This should fix it on the Windows theme, but if it is broken on other OSes, we will need to fix their skins, too.

Comment 9

[Maniac Vlad Florin (:vladmaniac)]

Hi all, I confirm it's a problem only for the windows themes. I've checked also Mac Snow Leopard(32-b) and Ubuntu 10.04(64-b).

Comment 10

[Daniel Brooks [:db48x]]

Comment on attachment 455390 [details] [diff] [review]
Patch v. 1.0

Yea, good catch. r=db48x

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 455390 [details] [diff] [review]
Patch v. 1.0

> #viewGroup > radio {
>   list-style-image: url("chrome://browser/skin/pageInfo.png");
>   -moz-box-orient: vertical;
>   -moz-box-align: center;
>   -moz-appearance: none;
>   padding: 5px 3px 1px 3px;
>+  margin: 0px 1px 0px 1px;

margin: 0 1px;

>+  min-width: 4.5em;
>+}
>+
>+#viewGroup > radio:hover {
>+	background-color: #E0E8F6;
>+	color: black;
>+}

fix indentation

Comment 12

[Tanner M. Young [:tmyoung]]

Attachment: Patch v. 1.1

Fixed.

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 455469 [details] [diff] [review]
Patch v. 1.1

I was going to say this doesn't need another review, but here's another nit:

> #viewGroup > radio {
>   list-style-image: url("chrome://browser/skin/pageInfo.png");
>   -moz-box-orient: vertical;
>   -moz-box-align: center;
>   -moz-appearance: none;
>   padding: 5px 3px 1px 3px;
>+  margin: 0px 1px;

s/0px/0/

Comment 14

[Tanner M. Young [:tmyoung]]

Attachment: Patch v. 1.2

Fixed and ready for landing.

Comment 15

[Ayan Shah[:ashah]]

I can reproduce this bug on Mac OS.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:2.0b1) Gecko/20100630 Firefox/4.0b1

Comment 16

[Tanner M. Young [:tmyoung]]

I am filing a separate bug for the Mac issue, since I don't have a Mac development environment; I can generate patches, but I can't test them (that I'm aware).  So I am limiting this bug to Windows Page Info issues regressed by the removal of the old extensions manager.

Comment 17

[Tanner M. Young [:tmyoung]]

I have filed Bug 576586 for Mac css issues.

Comment 18

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/49dec7e8ec3f