Closed Bug 560602 Opened 14 years ago Closed 14 years ago

browser_pageInfo.js times out

Categories

(Toolkit :: Add-ons Manager, defect, P1)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Whiteboard: [rewrite])

Attachments

(1 file)

patch rev 1
3.97 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
This is breaking a test on the branch and needs to be fixed before landing.
Fixed in http://hg.mozilla.org/projects/addonsmgr/rev/fc9746c1082e
Status: NEW → ASSIGNED
Flags: in-testsuite+
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
Flags: in-litmus-
Something still not right here.
Summary: Page info dialog assumes xpinstall.enabled exists → browser_pageInfo.js times out
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite]
http://hg.mozilla.org/projects/addonsmgr/rev/1f4541902ff3 should have fixed this now.
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
Attached patch patch rev 1 — — Splinter Review 

    
    

    
  
Comment on attachment 440350 [details] [diff] [review]
patch rev 1

This copies over the binding that page info was using from the extension manager, also stops assuming that the whitelist pref is there, it defaults to true in the new add-ons manager code.

        Attachment #440350 -
        Flags: review?(rflint)

    
    

    
  
Comment on attachment 440350 [details] [diff] [review]
patch rev 1

Stealing the review since I've already looked at the previous code as well as the patch.

        Attachment #440350 -
        Flags: review?(rflint) → review+
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr][needs-landing]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/2dcd870f9e31
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5

    
    

    
  
No orangeness. Marking as verified fixed.
Status: RESOLVED → VERIFIED
Depends on: 574676
Depends on: 576586

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: