browser_pageInfo.js times out

VERIFIED FIXED in mozilla1.9.3a5

Status

()

P1
normal
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Trunk
mozilla1.9.3a5
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [rewrite])

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
This is breaking a test on the branch and needs to be fixed before landing.
(Assignee)

Comment 1

9 years ago
Fixed in http://hg.mozilla.org/projects/addonsmgr/rev/fc9746c1082e
Status: NEW → ASSIGNED
Flags: in-testsuite+
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
Flags: in-litmus-
(Assignee)

Comment 2

9 years ago
Something still not right here.
Summary: Page info dialog assumes xpinstall.enabled exists → browser_pageInfo.js times out
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite]
(Assignee)

Comment 3

9 years ago
http://hg.mozilla.org/projects/addonsmgr/rev/1f4541902ff3 should have fixed this now.
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
(Assignee)

Comment 5

9 years ago
Comment on attachment 440350 [details] [diff] [review]
patch rev 1

This copies over the binding that page info was using from the extension manager, also stops assuming that the whitelist pref is there, it defaults to true in the new add-ons manager code.
Attachment #440350 - Flags: review?(rflint)
Comment on attachment 440350 [details] [diff] [review]
patch rev 1

Stealing the review since I've already looked at the previous code as well as the patch.
Attachment #440350 - Flags: review?(rflint) → review+
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr][needs-landing]
(Assignee)

Comment 7

9 years ago
http://hg.mozilla.org/mozilla-central/rev/2dcd870f9e31
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
No orangeness. Marking as verified fixed.
Status: RESOLVED → VERIFIED
Depends on: 574676
Depends on: 576586
You need to log in before you can comment on or make changes to this bug.