Closed
Bug 560602
Opened 15 years ago
Closed 15 years ago
browser_pageInfo.js times out
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Whiteboard: [rewrite])
Attachments
(1 file)
|
3.97 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
This is breaking a test on the branch and needs to be fixed before landing.
|
Assignee | |
Comment 1•15 years ago
|
||
Status: NEW → ASSIGNED
Flags: in-testsuite+
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
|
||
Updated•15 years ago
|
Flags: in-litmus-
|
|
Assignee | |
Comment 2•15 years ago
|
||
Something still not right here.
Summary: Page info dialog assumes xpinstall.enabled exists → browser_pageInfo.js times out
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite]
|
|
Assignee | |
Comment 3•15 years ago
|
||
http://hg.mozilla.org/projects/addonsmgr/rev/1f4541902ff3 should have fixed this now.
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
|
|
Assignee | |
Comment 4•15 years ago
|
||
|
|
Assignee | |
Comment 5•15 years ago
|
||
Comment on attachment 440350 [details] [diff] [review]
patch rev 1
This copies over the binding that page info was using from the extension manager, also stops assuming that the whitelist pref is there, it defaults to true in the new add-ons manager code.
Attachment #440350 -
Flags: review?(rflint)
|
||
Comment 6•15 years ago
|
||
Comment on attachment 440350 [details] [diff] [review]
patch rev 1
Stealing the review since I've already looked at the previous code as well as the patch.
Attachment #440350 -
Flags: review?(rflint) → review+
|
|
||
Updated•15 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr][needs-landing]
|
|
Assignee | |
Comment 7•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
You need to log in
before you can comment on or make changes to this bug.
Description
•