575449 - Firefox Menu Button appears on Javascript PopUp Windows - but Not in the Title bar

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[ronin.achilles]

User-Agent:       Mozilla/5.0(Windows; U; Windows NT 5.2; rv:1.9.2) Gecko/20100101 Firefox/3.6
Build Identifier: Mozilla/5.0(Windows; U; Windows NT 5.2; rv:1.9.2) Gecko/20100101 Firefox/3.6

The popup windows opened via javascript commands currently show the titlebar in the old style. The Firefox Button is pushed downwards, whereas it should either:
- Not appear at all OR
- Appear in the Title Bar

Reproducible: Always

Comment 1

[ronin.achilles]

Attachment: Firefox Button in Popup Windows

Comment 2

[[not reading bugmail]]

This is the probably the same or similar to bug 575291 but that bug doesn't have a screenshot.

Comment 3

[Fritz]

Attachment: Same issue in a slightly different position

Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:2.0b2pre) Gecko/20100629 Minefield/4.0b2pre

Same issue.  Reproducible for me, will try with a clean profile.

Comment 4

[Jim Mathies [:jimm]]

(In reply to comment #3)
> Created an attachment (id=454861) [details]
> Same issue in a slightly different position
> 
> Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:2.0b2pre)
> Gecko/20100629 Minefield/4.0b2pre
> 
> Same issue.  Reproducible for me, will try with a clean profile.

Thanks for pointing this out, was just working on it. Do you have a site that reproduces this? (It's a different bug really -  bug 575228.)

Comment 5

[Jim Mathies [:jimm]]

(In reply to comment #4)
> (In reply to comment #3)
> > Created an attachment (id=454861) [details] [details]
> > Same issue in a slightly different position
> > 
> > Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:2.0b2pre)
> > Gecko/20100629 Minefield/4.0b2pre
> > 
> > Same issue.  Reproducible for me, will try with a clean profile.
> 
> Thanks for pointing this out, was just working on it. Do you have a site that
> reproduces this? (It's a different bug really -  bug 575228.)

(I guess maybe espn might be a good guess..) ;)

Comment 6

[Jim Mathies [:jimm]]

Dao, any idea why we're picking up the maximized state from the other window on a popup window?

Comment 7

[[not reading bugmail]]

Would it be in the javascript?

Comment 8

[Dão Gottwald [:dao]]

I hadn't even noticed this yet. Must be a widget bug, I think. I'll test if this happens on Linux as well.

Comment 9

[Dão Gottwald [:dao]]

Also happens on Linux...

Comment 10

[Dão Gottwald [:dao]]

And with Firefox 3.6.3.

Comment 11

[Dão Gottwald [:dao]]

The really simple explanation for why the sizemode attribute is inherited to the popup is that the window element in browser.xul persists it. But I guess the persisted attribute is applied too late or some other code fails to clobber it.

Comment 12

[Dão Gottwald [:dao]]

filed bug 575725 on the sizemode issue

Comment 13

[Dão Gottwald [:dao]]

Attachment: patch

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 455405 [details] [diff] [review]
patch

>diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js

>+  var displayAppButton = menubarHidden &&
>+    document.documentElement.getAttribute("chromehidden").indexOf("menubar") == -1;

!window.menubar.visible

Comment 15

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/519d798e7855

Comment 16

[ronin.achilles]

I think this landed alongside Bug 571813. The Full Screen issue is resolved but I still see the App Button on Popup Windows. Will wait for the next hourly and report if it persists.

To reproduce - use the bookmarklet here... http://www.facebook.com/share_options.php

Comment 17

[[not reading bugmail]]

(In reply to comment #16)
> I still see the App Button on Popup Windows. 
> 
> To reproduce - use the bookmarklet here...
> http://www.facebook.com/share_options.php

This popup now returns the standard titlebar with text, no app menu, no custom titlebar and a location bar.  Did you try without any extensions or custom styling, clean profile?  Before it was the custom titlebar and app menu.

Comment 18

[ronin.achilles]

(In reply to comment #17)
> (In reply to comment #16)
> > I still see the App Button on Popup Windows. 
> > 
> > To reproduce - use the bookmarklet here...
> > http://www.facebook.com/share_options.php
> 
> This popup now returns the standard titlebar with text, no app menu, no custom
> titlebar and a location bar.  Did you try without any extensions or custom
> styling, clean profile?  Before it was the custom titlebar and app menu.

:) Very Strange... if you have browser.tabs.closeWindowWithLastTab set to False... you will see the Menu Button in Pop Up window... go figure!!

Comment 19

[[not reading bugmail]]

(In reply to comment #18)
> (In reply to comment #17)
> > (In reply to comment #16)
> > > I still see the App Button on Popup Windows. 
> > > 
> > > To reproduce - use the bookmarklet here...
> > > http://www.facebook.com/share_options.php
> > 
> > This popup now returns the standard titlebar with text, no app menu, no custom
> > titlebar and a location bar.  Did you try without any extensions or custom
> > styling, clean profile?  Before it was the custom titlebar and app menu.
> 
> :) Very Strange... if you have browser.tabs.closeWindowWithLastTab set to
> False... you will see the Menu Button in Pop Up window... go figure!!

Confirming, that case shows custom titlebar and app menu.

Comment 20

[[not reading bugmail]]

(In reply to comment #19)
> (In reply to comment #18)
> > browser.tabs.closeWindowWithLastTab set to False... you will see the Menu Button in Pop Up window

> Confirming, that case shows custom titlebar and app menu.

Or the regular titlebar I seen again with the appmenu showing.  Might want to file a separate bug for that.

Comment 22

[Dão Gottwald [:dao]]

(In reply to comment #15)
> http://hg.mozilla.org/mozilla-central/rev/519d798e7855

here's the right one: http://hg.mozilla.org/mozilla-central/rev/1f59c5f4d8d3