571813 - Firefox button should be hidden in full screen mode

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Shawn Thompson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a6pre) Gecko/20100613 Minefield/3.7a6pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a6pre) Gecko/20100613 Minefield/3.7a6pre

Alongside the other Aero bug we've been having with full screen mode, the introduction of the Firefox Button to nightly builds has also caused an issue, causing it to still appear if the toolbar is set to auto-hide.

Reproducible: Always

Steps to Reproduce:
1. Go into full screen mode on the default theme.
2. Set the toolbar to auto-hide
Actual Results:  
The Firefox Button remains visible on the handle for retracting the auto-hidden toolbar.

Expected Results:  
The button should either not be there, or be docked on the same line as the tabs in full screen mode.

Comment 1

[Shawn Thompson]

Attachment: Screenshot

Comment 2

[Shawn Thompson]

Oh, and also because of this, the hot spot for the reactivation of the toolbar ends up being the line below the strip with the button on it.

Comment 3

[[not reading bugmail]]

This is fixed with most recent hourly, please dupe against bug 575994 since that fixed it.

Comment 4

[[not reading bugmail]]

Scratch that, its still not fixed, but now you cannot use autohide now that bug 575994 is there.

Comment 7

[Dão Gottwald [:dao]]

Attachment: patch

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/519d798e7855

Comment 9

[Dão Gottwald [:dao]]

(In reply to comment #8)
> http://hg.mozilla.org/mozilla-central/rev/519d798e7855

err, http://hg.mozilla.org/mozilla-central/rev/1f59c5f4d8d3

Comment 10

[[not reading bugmail]]

(In reply to comment #9)
> err, http://hg.mozilla.org/mozilla-central/rev/1f59c5f4d8d3

--> Bug 575449.

Comment 11

[Alfred Kayser]

The button should only be hidden when the toolbar is hidden, but shown when the toolbar is not hidden, so that one can still access the appmenu when the toolbar is not hidden. In short, only hide the button when the toolbar is collapsed/hidden.

Comment 12

[[not reading bugmail]]

This is about full screenmode not maximized or normal mode.  Its not suppose to show at all. -  we didn't show the menubar in fullscreen mode before either.