Closed Bug 577002 Opened 10 years ago Closed 10 years ago

Remove nsICSSImportRule

Categories

(Core :: CSS Parsing and Computation, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: craig.topper, Assigned: craig.topper)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 4 obsolete files)

Only implemented by one class and doesn't need to exist.
Attached patch Part 1: Rename CSSImportRuleImpl (obsolete) — Splinter Review
Attachment #456078 - Flags: review?(dbaron)
Attachment #456080 - Flags: review?(dbaron)
Attachment #456081 - Flags: review?(dbaron)
FWIW, I'd probably use mozilla::css::ImportRule (CSSImportRule?) instead.
Depends on: deCOM
Blocks: deCOM
No longer depends on: deCOM
Blocks: 577976
Changed which header file I moved DECL_STYLE_RULE_INHERIT to.
Attachment #456794 - Flags: review?(dbaron)
Attachment #456794 - Attachment description: 456080: Part 2: Remove nsICSSImportRule and move nsCSSImportRule to header with a small change → Part 2: Remove nsICSSImportRule and move nsCSSImportRule to header with a small change
Attachment #456080 - Attachment is obsolete: true
Attachment #456080 - Flags: review?(dbaron)
Blocks: 577974
Attachment #456078 - Flags: review?(dbaron)
Attachment #456081 - Flags: review?(dbaron)
Attachment #456794 - Flags: review?(dbaron)
Attachment #456078 - Attachment is obsolete: true
Attachment #518979 - Flags: review?(bzbarsky)
Attachment #456794 - Attachment is obsolete: true
Attachment #518981 - Flags: review?(bzbarsky)
Attachment #456081 - Attachment is obsolete: true
Attachment #518982 - Flags: review?(bzbarsky)
Comment on attachment 518979 [details] [diff] [review]
Part 1: Rename CSSImportRuleImpl

r=me
Attachment #518979 - Flags: review?(bzbarsky) → review+
Comment on attachment 518981 [details] [diff] [review]
Part 2: Remove nsICSSImportRule

r=me though again we should consider getting rid of the NS_New method there and just making the ctor take the right arguments (and possibly eliminating the url setter?).

Also, I assume you checked that trying to QueryObject to css:ImportRule fails to compile?  If not, we need to make it do sane things, right?
Attachment #518981 - Flags: review?(bzbarsky) → review+
Comment on attachment 518982 [details] [diff] [review]
Part 3: Remove virtual and cleanup some return types

r=me
Attachment #518982 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/ecf6c47436b6
https://hg.mozilla.org/mozilla-central/rev/9ce52762e87a
https://hg.mozilla.org/mozilla-central/rev/5de818f2b992
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Priority: -- → P4
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.