Closed Bug 577236 Opened 14 years ago Closed 14 years ago

LaunchChild - [NSString stringWithCString] is deprecated

Categories

(Toolkit :: Application Update, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(2 files)

bug 577213 bumps the required version for the updater to 10.5

http://developer.apple.com/mac/library/documentation/Cocoa/Reference/Foundation/Classes/NSString_Class/Reference/NSString.html#//apple_ref/occ/clm/NSString/stringWithCString:encoding:

requires 10.4

toolkit/mozapps/update/updater/launchchild_osx.mm:
 In function ‘void LaunchChild(int, char**)’:
82: warning: ‘stringWithCString:’ is deprecated
84: warning: ‘stringWithCString:’ is deprecated
 (declared at /System/Library/Frameworks/Foundation.framework/Headers/NSString.h:386)
Attached patch proposalSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #456254 - Flags: review?(ted.mielczarek)
Attachment #456254 - Flags: review?(ted.mielczarek) → review?(robert.bugzilla)
this is an alternative based on some of what i've read...
Comment on attachment 456254 [details] [diff] [review]
proposal

Minusing because of bug 577237 comment #2. I suspect Josh Aas can answer whether to assume file system encoding
Attachment #456254 - Flags: review?(robert.bugzilla) → review-
i think bug 600362 fixed this
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: