577835 - Wrong error message when entering unknown / "invalid" URLs into "See also" field

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Thomas D. (:thomas8)]

STR

1 enter an URL into See Also field that is not accepted yet (like http://support.delicious.com/forum/comments.php?DiscussionID=549)

2 Look at error msg

Actual

Bugzilla shows this error msg (where {} indicates variables in the msg):

"{http://support.delicious.com/forum/comments.php?DiscussionID=549} is not a valid URL to a bug. Bug URLs should point to {show_bug.cgi} in a Bugzilla installation."

That msg is wrong and confusing, as we are already accepting bugs from installations other than Bugzilla (currently google code, debian).

Expected

The error message must be updated, otherwise it will confuse the user which values are allowed or not:

Apart from Bugzilla installations, see-also now accepts bugs from some different installations, and more to come/requested:

bug 532350 (fixed) Can't add Debian bug URLs to a bug using "See Also"
bug 533121 (fixed) Support Google Code for see_also urls
bug 543667 Support trac URLs in the "See Also" field
bug 558784 support JIRA links in see also
bug 571740 Cannot add getsatisfaction links/URLs to "See also" field

So the error msg should correctly reflect accepted values, at best something like this (or less):

"{http://support.delicious.com/forum/comments.php?DiscussionID=549} is not a valid URL to a bug. Bug URLs must point to one of the following bug installations:
{http://code.google.com/*
http://bugs.debian.org/*}"

If that looks complex, blame it on the complex concept of the "See also" field.
Things would be a lot easier if "See also" would just accept *any* URLs. Which would not prevent us from implementing automation (input shortcuts, friendly outputs, cross-system notifications) for those few systems that are explicitly supported.

Comment 1

[Thomas D. (:thomas8)]

(In reply to comment #0)
> So the error msg should correctly reflect accepted values, at best something
> like this (or less):
> "{http://support.delicious.com/forum/comments.php?DiscussionID=549} is not a
> valid URL to a bug. Bug URLs must point to one of the following bug
> installations:
> {http://code.google.com/*
> http://bugs.debian.org/*}"

Where I obviously missed the basic use case (bugzilla installations), and I have no way of knowing what exactly the patterns are that you check for google and debian, so just take the above as a sketch to refine.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Comment 3

[:glob ✱]

Comment on attachment 463973 [details] [diff] [review]
v1

>+        <li>A [% terms.bug %] on launchpad.net</li>
>+        <li>An issue on code.google.com.</li>
>+        <li>A [% terms.bug %] on b[% %]ugs.debian.org.</li>

we shouldn't be using terms.bug to refer to external entities, instead we should reference them by the same terminology that the external system uses.

launchpad calls them 'bugs', as does bugs.debian.org.

Comment 4

[Max Kanat-Alexander]

Attachment: v2

That's a really good point. :-)

Comment 5

[:glob ✱]

Comment on attachment 472579 [details] [diff] [review]
v2

r=glob

Comment 6

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified template/en/default/global/user-error.html.tmpl
Committed revision 7472.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/                         
modified template/en/default/global/user-error.html.tmpl
Committed revision 7402.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/                         
modified template/en/default/global/user-error.html.tmpl
Committed revision 7173.