Closed
Bug 578322
Opened 14 years ago
Closed 14 years ago
Remove support for <popup> from all themes
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla2.0b2
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
5.37 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
We have only partial support for this right now, and it's regression prone since we don't use <popup> ourselves anymore.
Attachment #457044 -
Flags: review?(enndeakin)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 457044 [details] [diff] [review] patch This is ok but you should document this somewhere and inform others about this change. Also, Thunderbird and Seamonkey (for example) do still have <popup> throughout their code.
Attachment #457044 -
Flags: review?(enndeakin) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
updated https://developer.mozilla.org/en/Firefox_4_for_developers#Miscellaneous_XUL_changes and https://developer.mozilla.org/en/XUL/popup and filed bug 578440 and bug 578441
Keywords: dev-doc-complete
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6d5be6f065c8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3b2
|
||
Comment 4•14 years ago
|
||
This broke pop-ups from right-click context menus for addons that are in the status-bar, i.e. ABP, AniWeather, or any addon that for now works in the status-bar. The context menu shows, but it is 'transparent'. Intentional that they broke, or was this for 'themes' only ?
|
|
Assignee | |
Comment 5•14 years ago
|
||
It affects add-ons that use <popup> instead of <menupopup>, it has nothing to do with the status bar per se.
Two more extension that are affected Live HTTP Header, AdBlock Plus (bug 584566)
You need to log in
before you can comment on or make changes to this bug.
Description
•