578373 - Update Tabbed Browsing API for Tab Animation

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aaron Train [:aaronmt]]

Currently, Mozmill tab manipulating tests such as bug 552594 and bug 557799 are failing on trunk.

With bug 543206, when we open new tabs, via middle click or right click context menu, we will have to add an event listener to the testTabbedBrowsingAPI that will listen for 'transitionend'.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right, adding an event listener for 'transitionend' should do the trick. We should also check for the tab closing animation, once it has been landed on bug 380960.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1 (default) [checked-in]

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 460074 [details] [diff] [review]
Patch v1 (default) [checked-in]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/4e75e1a2e03a

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch (1.9.2/1.9.1)

Backport to use the TabOpen event for older branches.

Comment 5

[u279076]

Comment on attachment 461172 [details] [diff] [review]
Patch (1.9.2/1.9.1)

> var MODULE_NAME = 'TabbedBrowsingAPI';
> 
>+// Include necessary modules
>+var RELATIVE_ROOT = '.';
>+var MODULE_REQUIRES = ['UtilsAPI'];
>+
> const gTimeout = 5000;
> 
> const tabsBrowser = '/id("main-window")/id("browser")/id("appcontent")/id("content")';
> const tabsStrip = tabsBrowser + '/anon({"anonid":"tabbox"})/anon({"anonid":"strip"})';
> const tabsContainer = tabsStrip + '/anon({"anonid":"tabcontainer"})/anon({"class":"tabs-stack"})/{"class":"tabs-container"}';
> const tabsArrowScrollbox = tabsContainer + '/anon({"anonid":"arrowscrollbox"})';
> 

nit: Can we update this module to use ALL_CAPS for const names to come in line with our test and coding style guidelines?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

That shouldn't be part of this bug. Once we rewrite all our shared modules we will take this into account.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 461172 [details] [diff] [review]
Patch (1.9.2/1.9.1)

Reasking for review. Please see my last comment.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With bug 380960 our closeTab() method of the tabBrowser class needs the update asap because it breaks all of our tests which make use of tabbed browsing with the upcoming Mozmill 1.4.2 release. I will work on the implementation later today.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

Our default behavior to work with tabs shouldn't take care of the tab animation. It slows down the test execution drastically. If there are no other automated tests we should create a special test for animation in a later stage.

For now, we will disable the animation and simply listen for the TabOpen and TabClose events.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Follow-up v1.1 (default) [checked-in]

Now without the accidental changes in other tests.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 464811 [details] [diff] [review]
Follow-up v1.1 (default) [checked-in]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/e9537b619d93

Comment 12

[Aaron Train [:aaronmt]]

Verified fixed with this http://hg.mozilla.org/qa/mozmill-tests/rev/e9537b619d93, the problem yesterday is eliminated

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Backport v1 (1.9.2, 1.9.1)

This is a combined backport patch for the already checked-in patches. Lets get this landed on the branches too, except the tab animation lines.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Backport patch landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/652f73dde65f (1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/088eb8b86608 (1.9.1)

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.