581037 - [mozmill] Unknown entity failure in testNewTab.js (default)

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aaron Train [:aaronmt]]

MODULE: /firefox/testTabbedBrowsing/testNewTab     
TEST: testNewTab.js
FAIL: getEntity: Unknown entity - newTab.label
BRANCH: default

This is most likely a result of the tab animation in 4.0, see bug 578373

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

No, it's a regression from the context menu removal on bug 579720. We should use the entry from the properties file instead. Aaron, do you wanna do that quick and straight forward fix?

Comment 2

[Aaron Train [:aaronmt]]

Attachment: Entity to Properties fix

Comment 3

[Aaron Train [:aaronmt]]

Attachment: Updates comment

Updates comment from 'Untitled' to 'New Tab'

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 459460 [details] [diff] [review]
Updates comment

>+  var title = UtilsAPI.getProperty(["chrome://browser/locale/tabbrowser.properties"],
>+                                  "tabs.emptyTabTitle");

Nit: Please check for the correct indentation the next time. I will fix it now. r=me.

Please also create a backport fix for 1.9.2 and 1.9.1.

Comment 5

[Aaron Train [:aaronmt]]

Attachment: Backport 1.9.1/1.9.2

Comment 6

[Aaron Train [:aaronmt]]

Attachment: Backport 1.9.1

Comment 7

[Aaron Train [:aaronmt]]

Attachment: Backport 1.9.2

Comment 8

[Aaron Train [:aaronmt]]

Attachment: default - nit fix

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 459468 [details] [diff] [review]
Backport 1.9.2

>-  // The tabs title should be 'Untitled'
>+  // The tabs title should be 'New Tab'
>   var title = UtilsAPI.getProperty("chrome://browser/locale/tabbrowser.properties",
>-                                   "tabs.untitled");
>+                                   "tabs.emptyTabTitle");

Sure, that you wanted to have this for 1.9.2? I can't find emptyTabTitle at all on mozilla1.9.2:
http://mxr.mozilla.org/mozilla1.9.2/search?string=emptyTabTitle

Also it should be Untitled and not New Tab.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 459467 [details] [diff] [review]
Backport 1.9.1

Same here. I assume you mixed up your patches.

Comment 11

[Aaron Train [:aaronmt]]

1.9.1 - http://hg.mozilla.org/qa/mozmill-tests/file/32dec3f817b5/firefox/testTabbedBrowsing/testNewTab.js

1.9.2 - http://hg.mozilla.org/qa/mozmill-tests/file/2d7bb1b96cdc/firefox/testTabbedBrowsing/testNewTab.js

default - http://hg.mozilla.org/qa/mozmill-tests/file/04fecdc66faa/firefox/testTabbedBrowsing/testNewTab.js

Some confusion here, 1.9.1 and 1.9.2 already read from property files.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dao, those tests are for tabbed browsing and not for the Mozmill product. It's the same as all the other automated tests.

(In reply to comment #11)
> Some confusion here, 1.9.1 and 1.9.2 already read from property files.

That's even better. I will check-in the default patch.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on default as:
http://hg.mozilla.org/qa/mozmill-tests/rev/dea6672ec407

Comment 14

[Dão Gottwald [:dao]]

We don't need [e-mail] people to read this stuff. It's not a bug in tabbrowser, the code is in the mozmill tree and not managed by tabbrowser people.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #14)
> We don't need [e-mail] people to read this stuff. It's not a
> bug in tabbrowser, the code is in the mozmill tree and not managed by
> tabbrowser people.

So you create bugs for failures in existent Mochitests in the Mochitest component? I have never seen that. Please give me references for that! Mozmill tests are tests which are already present in mozilla-central and will also be handled there in the near future. That absolutely qualifies the tabbrowser component.

Comment 16

[Dão Gottwald [:dao]]

(In reply to comment #15)
> (In reply to comment #14)
> > We don't need [e-mail] people to read this stuff. It's not a
> > bug in tabbrowser, the code is in the mozmill tree and not managed by
> > tabbrowser people.
> 
> So you create bugs for failures in existent Mochitests in the Mochitest
> component?

No, I don't, I file them in Firefox:Tabbed Browser, for instance, so that the people managing the tests (e.g. those watching [e-mail]) know about it. Note that: People managing these tests and people managing tabbrowser code are the same; they are distinct from those managing mozmill tests.

If however a mozmill test reveals a tabbrowser bug, that's a different story, because then we do need tabbrowser people to know about it.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #16)
> > So you create bugs for failures in existent Mochitests in the Mochitest
> > component?
> 
> No, I don't, I file them in Firefox:Tabbed Browser, for instance, so that the
> people managing the tests (e.g. those watching [e-mail])
> know about it. Note that: People managing these tests and people managing
> tabbrowser code are the same; they are distinct from those managing mozmill
> tests.

Well, Mozmill is just another test framework beside Mochitest and others. Those tests should also be placed in the relevant product/component they belong to. We shouldn't make a difference here, even they are located and managed in another repository for now. Means tests for the tab browser should end up in Firefox:Tabbed Browser, or tests related to security in Firefox:Security.

Testing:Mozmill is the product (framework) itself and is similar to Testing:Mochitest. It has nothing to do with the tests we are writing for specific components of Firefox. 

> If however a mozmill test reveals a tabbrowser bug, that's a different story,
> because then we do need tabbrowser people to know about it.

Test creation and solving failures should all be handled in the same component. So I'm not sure, why you do not want to have those in tabbrowser. You can simply filter them out, but others can be interested in.

If we can't make a clear decision here, I will start a newsgroup thread on that topic. Further discussions shouldn't clutter this bug.

Comment 18

[Dão Gottwald [:dao]]

(In reply to comment #17)
> Well, Mozmill is just another test framework beside Mochitest and others. Those
> tests should also be placed in the relevant product/component they belong to.
> [...]

You seem to ignore my argument that the QA contact is different? Different people are managing that stuff, we should differentiate when notifying them.

> So I'm not sure, why you do not want to have those in tabbrowser. You can
> simply filter them out, but others can be interested in.

Where would I filter them out? I can watch [e-mail] in <https://bugzilla.mozilla.org/userprefs.cgi?tab=email>, but it doesn't look like I could exclude [mozmill] there. Obviously I wouldn't want to drop [mozmill] e-mails from my inbox in general, as this would affect bugs I'm actually CC'd on.

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #18)
> > Well, Mozmill is just another test framework beside Mochitest and others. Those
> > tests should also be placed in the relevant product/component they belong to.
> > [...]
> 
> You seem to ignore my argument that the QA contact is different? Different
> people are managing that stuff, we should differentiate when notifying them.

So we can move it to Firefox:Tabbed Browser but leave the qa contact at  	
[e-mail]. Would that be an option for you?

Comment 20

[Dão Gottwald [:dao]]

Sounds good to me.

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.