578671 - Sync which engines are enabled across clients, wipe data for disabled engines

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

The choice which engines to sync (engine.enabled) should affect all clients, not just the one you're making the choice on. Once a particular engine is disabled, its data should also be wiped on the server.

Engine.enabled is persisted as a preference, but since the preference engine could be disabled just as well, we can't really use it to sync that info. The meta/global WBO seems like a good place (inside the 'engines' hash) since it's checked before every sync anyway.

Comment 1

[Ed Lee :Mardak]

Bug 563459 is probably related.

Comment 2

[Philipp von Weitershausen [:philikon]]

Yes, syncing which engines are enabled implies prepopulating those checkboxes.

Comment 4

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Observe and remember when the engine enabled prefs change. Upon the next sync, check for newly enabled or disabled engines both remotely and locally. Presence in meta/global's engines object is interpreted as being enabled.

Comment 5

[Philipp von Weitershausen [:philikon]]

Attachment: strings v1

Change strings to indicate that the engine setting is no longer contained to each individual computer.

Comment 6

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/services/fx-sync/rev/5571f5038b93
http://hg.mozilla.org/services/fx-sync/rev/9bd8a5592b2f

Comment 7

[Ragavan S [:rags]]

I was recently playing with this on Minefield and noticed that I didn't get any message saying whether pre-existing data on the server will be deleted or if it will remain there? I think we should let users know what happens as it is not immediately obvious.

Comment 8

[Mike Connor [:mconnor]]

Please file a followup on that and we can discuss it in that bug?

Comment 9

[Ragavan S [:rags]]

Filed: https://bugzilla.mozilla.org/show_bug.cgi?id=607407