57932 - duplication in drop-down history: "stuff" and "http://stuff"

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, defect, P4)

Description

[Azrael AOD]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.15 i686; en-US; m18) Gecko/20001024
BuildID:    2000102408

Drop down history/visted pages widget next to location bar duplicate with
http:// in front.
So will have eg: http://slashdot.org/index.pl
		 slashdot.org/index.pl


Reproducible: Always
Steps to Reproduce:
Type into your location bar: slashdot.org/index.pl
Wait for page to load with http:// in front of what you typed, then simply click
in the location bar and press return (essentially reloading it)
Check the drop-down.. and the one address appears twice.. once with 'http://' in
front.
To me this is a bug...

Actual Results:  Duplication

Expected Results:  Smart checking to ignore the http:// in front .. or to
include it as default on all entries.. to differentiate between any other
protocols...

I think that if Moz is going to list visited pages that one types into the
address bar, then it ought to be smart enough to know which addresses duplicate
each other... I see this as just an extension of the check it must currently
do.. rather than checking for _exact_ match.. just match the current location
_minus_ the http:// with all existing entries.
Or to include the http:// in the actual recorded information. Theoretically a
very simple 'bug' fix.
I'm marking this as a trivial bug.. but still if it is very simple to correct I
think it is very important it be done.

Comment 1

[Chris Siebenmann]

 I'm seeing this bug on today's CVS build on Linux. Confirming.

 Perhaps the solution is to not add anything to the dropdown history bar
until after it's been canonicalized through various processes.

Comment 2

[Cyd]

Marking as dupe of bug 49913, "pressing enter in URL field adds a duplicate
entry to session history."


*** This bug has been marked as a duplicate of 49913 ***

Comment 3

[Radha on family leave (not reading bugmail)]

This is not a dupe of 49913. Re-opening and assigning to self. Urlbar History
and Session History are different.

Comment 4

[Radha on family leave (not reading bugmail)]

I don't completely agree with the bug. Urlbar History is suppose to just keep 
track of what was entered rather than take decisions for the user on what to 
keep and what not to keep. The user may want to go back and edit what he 
entered.I have attacehd a patch to bug 60678 where the autocompletion code 
figures that slashdot.org and http://slashdot.org are the same and provides only  
one result. 

Comment 5

[Azrael AOD]

I think URLbar history should track only valid URLs.
I agree there should be a way to edit it.
But if mozilla pops up when I'm typing in another window, and I accidently go 
to a URL of: 'and a pound of bacon and six eggs' I don't really want that 
hanging around in the URL bar history.
Nor is it necessary to keep duplicates, with or without http:// on the front.
I'm not sure how far your patch to bug 60678 (well done) helps in this bug... 
but if we can't have a 'smart' urlbar history, we need it to be editable at 
least.

Comment 6

[Alec Flett]

moving these bugs to History: URLBar

Comment 7

[Jesse Ruderman]

Updating summary to differentiate from bug 77173, duplication in drop-down 
history: "host" and "host/"

Comment 8

[Paul Chen]

nav triage team:

Now that we've got auto completion, it's even more complicated. At any rate, not
a mozilla1.0 stopper. Marking mozilla1.2

Comment 9

[Alec Flett]

reassign url bar bugs to new owner..

Comment 10

[Blake Ross]

Joe was dying to have these bugs. Who am I to say no?

Comment 11

[Igor Nekrestyanov]

Should be fixed with proposed fix for bug 92132

Comment 12

[Azrael AOD]

I think this is fixed! Marking so - 'cause wfm w/ 2002061604