Closed Bug 579470 Opened 10 years ago Closed 10 years ago

POP3 status message "checking %S for new messages" is incorrectly capitalized

Categories

(Thunderbird :: Message Reader UI, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a1

People

(Reporter: Mly, Assigned: ewong)

Details

(Whiteboard: [good first bug])

Attachments

(1 file, 3 obsolete files)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.4) Gecko/20100611 Firefox/3.6.4
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1

pop3EventStartDisplayText=checking %S for new messages
in comm-central/ mail/ locales/ en-US/ chrome/ messenger/ activity.properties  
should read
pop3EventStartDisplayText=Checking %S for new messages


Reproducible: Always

Steps to Reproduce:
1. Type command-T (get new mail) when a POP3 mailbox is selected


Actual Results:  
Lowercase "checking Inbox for new messages" is displayed in the status bar.

Expected Results:  
Conventional English orthography, please!
"Checking Inbox for new messages"

Trivial.

And of course not nearly as utterly infuriating and constantly in everybody's face as the unacceptable "WONTFIXSCREWYOU" Bug 541145 and Bug 478468.

But it would be nice to have the one character fix.  Thanks!
Keywords: helpwanted
Whiteboard: [good first bug]
Status: UNCONFIRMED → NEW
Ever confirmed: true
If we're making it into an English sentence, shouldn't there be a period at the end too?
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #463558 - Flags: ui-review? → ui-review?(nisses.mail)
OS: Mac OS X → All
(In reply to comment #2)
>-pop3EventStatusText=#1 message downloaded;#1 messages downloaded
>+pop3EventStatusText=#1 message downloaded;#1 messages downloaded.
Perhaps full stop also should be added to single form of this sentence, e.g.:

pop3EventStatusText=#1 message downloaded.;#1 messages downloaded.

Same goes for all strings in patch that using plural forms.
Added full stop to single form of sentences.  Added also a few more full stops
to sentences that were missed by the first patch.
Attachment #463558 - Attachment is obsolete: true
Attachment #463745 - Flags: ui-review?
Attachment #463558 - Flags: ui-review?(nisses.mail)
Attachment #463745 - Flags: ui-review? → ui-review?(nisses.mail)
Comment on attachment 463745 [details] [diff] [review]
Completed sentences with full stops and Upper cased the specified "Checking"  (v2)

A bit tricky to trigger all of these, but looking at the code, all of the changes seems to make sense in the UI. The only potential risk would be if these ended up in the middle of a sentence, but I don't see that happening.
Attachment #463745 - Flags: ui-review?(nisses.mail) → ui-review+
1) I'm not sure if punctuation adjustments constitute semantic change, but if they do, you might also want to change entity names in order for localizers to notice the change.

2) I'm not so confident if full stop is the correct punctuation marks to denote work in progress (checking, copying, etc.). IMO, ellipsis would work better. Though I probably don't quite agree with comment #2 that these messages actually need punctuation at all.

2-alt) Some messages still lack punctuation at the end. Examples are strings with %S (message subject) at the end, failedToSendMessage, and failedToCopyMessage.

3) The L10N note for sendingMessageWithSubject is misplaced. You could fix this too.


I haven't looked more thoroughly through the patch, but I really don't think we need dots there. IMO, the problem described in the bug title and perhaps placing of the L10n note are the only things that need fixing here.
Changed the patch to fix the actual bug, plus the added 
moving the L10N note for sendingMessageWithSubject to
the right place.
Attachment #463745 - Attachment is obsolete: true
Attachment #467399 - Flags: ui-review?(nisses.mail)
Attachment #467399 - Flags: review?(bwinton)
Regarding punctuation or no punctuation, that is now bug 588759.
Comment on attachment 467399 [details] [diff] [review]
POP3 status message "checking %S for new messages" is incorrectly capitalized (v2)

r=me, if you get rid of the "." at the end of "Checking %S for new messages.".  (We can do that as part of bug 588759.)
Attachment #467399 - Flags: review?(bwinton) → review+
Attachment #467399 - Attachment is obsolete: true
Attachment #467678 - Flags: ui-review?(nisses.mail)
Attachment #467678 - Flags: review+
Attachment #467399 - Flags: ui-review?(nisses.mail)
Comment on attachment 467678 [details] [diff] [review]
POP3 status message "checking %S for new messages" is incorrectly capitalized (v3)

Looks good!
Thanks for the patch Edmund!
Attachment #467678 - Flags: ui-review?(nisses.mail) → ui-review+
Checked in: http://hg.mozilla.org/comm-central/rev/76a8c6d2ce4c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
You need to log in before you can comment on or make changes to this bug.